Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the range of copyright years at the footer #436

Closed
Tracked by #1818 ...
nghialv opened this issue Jan 29, 2021 · 5 comments · Fixed by #1821
Closed
Tracked by #1818 ...

Allow configuring the range of copyright years at the footer #436

nghialv opened this issue Jan 29, 2021 · 5 comments · Fixed by #1821
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nghialv
Copy link
Contributor

nghialv commented Jan 29, 2021

Hello.

Thank you for a great OSS.
We are using Docsy for all of our OSS products and we really love Docsy.

Currently, Docsy is fixing the year in copyright part with the current year.
It would be nice if we can configure that field. For example, to be "2020 - 2021".

Thanks.

@LisaFC
Copy link
Collaborator

LisaFC commented Jan 29, 2021

Gotcha. I'll see if I can come up with a nice way of parameterizing it, though in the meantime you could create your own version of the footer file for your project, and just swap out {{ now.Year }} with your custom value:

https://github.com/google/docsy/blob/master/layouts/partials/footer.html#L20

Are you likely to always have the current year as the end of your range (and does anyone else have any special requirements)?

@LisaFC
Copy link
Collaborator

LisaFC commented Jan 29, 2021

Aha, I see from your linked PR you have already done that! :)

@nghialv
Copy link
Contributor Author

nghialv commented Jan 29, 2021

Yes. We temporarily fixed it by overriding the footer.html file.

Are you likely to always have the current year as the end of your range (and does anyone else have any special requirements)?

Yes. It will be like this.

https://pipecd.dev/

Thanks.

@yann-soubeyrand
Copy link
Contributor

Hello, this is not exactly fixing your issue, but this should allow for an easier footer override: #1500.

@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
@chalin chalin modified the milestones: 24Q2, 24Q1 Feb 2, 2024
@chalin chalin added the enhancement New feature or request label Feb 2, 2024
@chalin chalin self-assigned this Feb 2, 2024
@chalin
Copy link
Collaborator

chalin commented Feb 2, 2024

From #2 (comment), @emckean wrote:

+1 to copyright not being automatically updated to current year. If you wanted to make sure the footer was always up to date you could do $originYear – {{ now.Year }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants