Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap git submodule v4.5.3, not in sync with partials/scripts.html (still v4.6.0) #632

Closed
pschrey2 opened this issue Jul 14, 2021 Discussed in #631 · 1 comment
Closed

Comments

@pschrey2
Copy link
Contributor

Discussed in #631

Originally posted by pschrey2 July 13, 2021
Hi, bootstrap seems to be switched back to version 4.5.3 on May 29 with commit c5f1613 (see git submodule bootstrap at https://github.com/google/docsy/tree/master/assets/vendor).
Any reason for that?
Regards, Patrik

Happened by mistake during PR #554. Can the /assets/vendor/bootstrap git submodule be refered back to version 4.6.0?
Because now the submodule and https://github.com/google/docsy/blob/master/layouts/partials/scripts.html are not in sync.

The upgrade was done earlier by @deining on April 12 (8b2f695#diff-05e01d0fe33a568f907cb8c03ee25e8cef7221d73f052ac04392232753d25467) plus an SRI hash fix later on April 17.

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 14, 2021

Done! (also I hate updating git submodules, it always feels like bomb disposal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants