Changes introducing hugo.IsProduction were overwritten

[chalin]

Originally posted by @chalin in #611 (comment)

---

@LisaFC et al.: somehow #540 reverted #413. The latter introduced the use of hugo.IsProduction, in replacement of the environment-variable checking code. IMHO, use of hugo.IsProduction is the better (if not proper) way to determine the build environment, in particular since the build environment can be specified using the -e flag command line flag.

Possibly related: #611
Related: #651

/cc @nate-double-u

[LisaFC]

Ahhh, thanks for spotting this. And yes, agreed that hugo.IsProduction is definitely the way to go.

I'll send a mail to the mailing list when we merge/fix this and update the docs, as this will be a breaking change for some users (ie their site will be indexed by default).

[LisaFC]

(apologies for late reply, I was on vacation)

[chalin]

No worries. I hope that you had a great vacation!