Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Web Edit option #777

Open
Tracked by #1841
petr-stupka opened this issue Nov 23, 2021 · 6 comments
Open
Tracked by #1841

GitHub Web Edit option #777

petr-stupka opened this issue Nov 23, 2021 · 6 comments
Labels
e0-minutes Effort < 60 min

Comments

@petr-stupka
Copy link

Hi, GitHub now have "Web Editor" functionality if you press . on the file so you can edit it in VS code web instead of the simple edit this file in GitHub UI.

The idea is to an have configuration option where to edit page? This can be just a different link selection:

GitHub Edit url:

https://github.com/<USERNAME>/<REPOSITORY>/edit/main/quickstart/content/en/docs/_index.md

VS Code web url:

https://github.dev/<USERNAME>/<REPOSITORY>/blob/main/quickstart/content/en/docs/_index.md

Root url changed from github.com to github.dev and navigation from edit to blob

@LisaFC
Copy link
Collaborator

LisaFC commented Nov 23, 2021

Ooh, just tried that and it's really nice! @chalin what do you think?

@petr-stupka
Copy link
Author

I just copied my post from one of the chalin issue over, so it will not get forgotten since this is pretty cool feature from GitHub, agree

@chalin
Copy link
Collaborator

chalin commented Nov 23, 2021

I haven't had time to try this again, but from what I recall, after being thrown into the editor and making changes, it didn't seem obvious how to submit a PR. That use case should be well supported / documented since folks will be editing a file with the intention of submitting a PR. The old interface makes that easy.

Regardless, we can still consider adding such a repo link.

@gwatts
Copy link
Contributor

gwatts commented Nov 24, 2021

I agree with @chalin - you enter a far more complicated workflow if you land someone straight into vscode. The current github editor makes things pretty straightforward if someone just wants to fix a typo, add a sentence, etc.

@petr-stupka
Copy link
Author

Thanks for your feedback.
May be optional i.e. Edit this Page in Web Editor button will be the best solution?

@chalin
Copy link
Collaborator

chalin commented Nov 30, 2021

May be optional i.e. Edit this Page in Web Editor button will be the best solution?

All buttons are now optional in that they can be disabled. For details see Disabling links. So in that sense I wouldn't be against the addition.

(We might debate whether the button should be shown by default or not.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Effort < 60 min
Projects
None yet
Development

No branches or pull requests

4 participants