Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome static files seem 3 years old? #872

Closed
hugonijmek opened this issue Feb 1, 2022 · 3 comments · Fixed by #1102 or #1164
Closed

Font Awesome static files seem 3 years old? #872

hugonijmek opened this issue Feb 1, 2022 · 3 comments · Fixed by #1102 or #1164
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@hugonijmek
Copy link

Good day to whoever reads this. I was trying to load the fab fa-discord icon from Font Awesome. However I was greeted with the old discord logo. I checked which logo they supplied and since the latest version it should be the new logo. So to be sure I updated the font awesome sub module but still got the old discord logo showing up. So I dug a bit deeper and at the moment I’m thinking it’s caused by the webfonts folder in the static folder that seems to have been updated 3 years ago for the last time. I also noticed these files don’t get updated when we bump the font awesome package. So 2 questions;

  1. Should I manually update the files in the webfonts folder to be able to use the latest font awesome icons?
  2. Should we think of a way to automatically update these files on a version bump?
@LisaFC
Copy link
Collaborator

LisaFC commented Feb 2, 2022

Huh, that's strange - I didn't set up the original FontAwesome integration so I'm not sure why that static directory is there. Let me investigate.

@hugonijmek
Copy link
Author

@LisaFC Just to follow up. I added the static files in my Hugo Project so it would overwrite those. And it indeed fixes the issue of the old logo. So it would seem that these static files are used somehow.

@chalin
Copy link
Collaborator

chalin commented Aug 15, 2022

FYI, the following PR proposed that we drop the webfonts. WDYT?

Also related is:

@chalin chalin added the dependencies Pull requests that update a dependency file label Aug 15, 2022
@chalin chalin self-assigned this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
3 participants