From 249a4c2ed5ef0d808584d1808e32e61cae3f3709 Mon Sep 17 00:00:00 2001
From: Patrice Chalin <pchalin@gmail.com>
Date: Fri, 11 Aug 2023 05:59:47 -0400
Subject: [PATCH 1/3] Fix left-nav height and padding (no vars)

---
 assets/scss/_sidebar-tree.scss     | 32 ++++++++++++++++++++++++------
 layouts/partials/sidebar-tree.html |  5 ++++-
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/assets/scss/_sidebar-tree.scss b/assets/scss/_sidebar-tree.scss
index a7b92bb4cc..855ab109b7 100644
--- a/assets/scss/_sidebar-tree.scss
+++ b/assets/scss/_sidebar-tree.scss
@@ -2,17 +2,39 @@
 // Left side navigation
 //
 .td-sidebar-nav {
+  $_max-height: calc(100vh - 8.5rem);
+
   padding-right: 0.5rem;
   margin-right: -15px;
   margin-left: -15px;
 
   @include media-breakpoint-up(md) {
     @supports (position: sticky) {
-      max-height: calc(100vh - 10rem);
+      max-height: $_max-height;
       overflow-y: auto;
     }
   }
 
+  // Adjust height and padding when sidebar_search_disable is true
+  &.td-sidebar-nav--search-disabled {
+    padding-top: 1rem;
+
+    @include media-breakpoint-up(md) {
+      @supports (position: sticky) {
+        max-height: calc(#{$_max-height} + 4.5rem);
+      }
+    }
+  }
+
+  // Handle the case where #content-mobile is displayed with a search box,
+  // regardless of the value of sidebar_search_disable:
+  @include media-breakpoint-only(md) {
+    padding-top: 0 !important;
+    @supports (position: sticky) {
+      max-height: $_max-height !important;
+    }
+  }
+
   @include media-breakpoint-up(md) {
     display: block !important;
   }
@@ -22,7 +44,7 @@
       list-style: none;
     }
 
-    ul {
+    &.ul-0, ul {
       padding: 0;
       margin: 0;
     }
@@ -119,9 +141,7 @@
   }
 
   &__search {
-    padding: 1rem 15px;
-    margin-right: -15px;
-    margin-left: -15px;
+    padding: 1rem 0;
   }
 
   &__inner {
@@ -132,7 +152,7 @@
         position: sticky;
         top: 4rem;
         z-index: 10;
-        height: calc(100vh - 6rem);
+        height: calc(100vh - 5rem);
       }
     }
 
diff --git a/layouts/partials/sidebar-tree.html b/layouts/partials/sidebar-tree.html
index 60f583c111..2ce0c56373 100644
--- a/layouts/partials/sidebar-tree.html
+++ b/layouts/partials/sidebar-tree.html
@@ -18,7 +18,10 @@
   </div>
   <div id="content-desktop"></div>
   {{ end -}}
-  <nav class="collapse td-sidebar-nav{{ if .Site.Params.ui.sidebar_menu_foldable }} foldable-nav{{ end }}" id="td-section-nav">
+  <nav class="td-sidebar-nav collapse
+      {{- if .Site.Params.ui.sidebar_search_disable }} td-sidebar-nav--search-disabled{{ end -}}
+      {{- if .Site.Params.ui.sidebar_menu_foldable }} foldable-nav{{ end -}}
+      " id="td-section-nav">
     {{ if  (gt (len .Site.Home.Translations) 0) -}}
     <div class="td-sidebar-nav__section nav-item dropdown d-block d-lg-none">
       {{ partial "navbar-lang-selector.html" . }}

From aa6e65f8233424ff020bf73cedb710137eb529f4 Mon Sep 17 00:00:00 2001
From: Patrice Chalin <pchalin@gmail.com>
Date: Fri, 11 Aug 2023 06:31:01 -0400
Subject: [PATCH 2/3] Fix top padding on modile

---
 assets/scss/_sidebar-tree.scss | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/assets/scss/_sidebar-tree.scss b/assets/scss/_sidebar-tree.scss
index 855ab109b7..d1623c0168 100644
--- a/assets/scss/_sidebar-tree.scss
+++ b/assets/scss/_sidebar-tree.scss
@@ -26,9 +26,9 @@
     }
   }
 
-  // Handle the case where #content-mobile is displayed with a search box,
-  // regardless of the value of sidebar_search_disable:
-  @include media-breakpoint-only(md) {
+  // Handle cases for tablet (`md`) and mobile (<= `sm`) where the search box is
+  // displayed regardless of the value of sidebar_search_disable:
+  @include media-breakpoint-down(lg) {
     padding-top: 0 !important;
     @supports (position: sticky) {
       max-height: $_max-height !important;

From 6652fd355b3f7985af8cf0d04a73a4df17851a7a Mon Sep 17 00:00:00 2001
From: Patrice Chalin <pchalin@gmail.com>
Date: Fri, 11 Aug 2023 06:52:09 -0400
Subject: [PATCH 3/3] Simplify styling: combine cases

---
 assets/scss/_sidebar-tree.scss | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/assets/scss/_sidebar-tree.scss b/assets/scss/_sidebar-tree.scss
index d1623c0168..50beb4e119 100644
--- a/assets/scss/_sidebar-tree.scss
+++ b/assets/scss/_sidebar-tree.scss
@@ -15,26 +15,21 @@
     }
   }
 
-  // Adjust height and padding when sidebar_search_disable is true
+  // Adjust height and padding when sidebar_search_disable is true, but only for
+  // >= `lg` views, because on tablet (`md`) and mobile (<= `sm`), the search
+  // box is displayed regardless of the value of sidebar_search_disable:
   &.td-sidebar-nav--search-disabled {
-    padding-top: 1rem;
+    @include media-breakpoint-up(lg) {
+      // There's no search box so add top padding
+      // and adjust max-height:
+      padding-top: 1rem;
 
-    @include media-breakpoint-up(md) {
       @supports (position: sticky) {
         max-height: calc(#{$_max-height} + 4.5rem);
       }
     }
   }
 
-  // Handle cases for tablet (`md`) and mobile (<= `sm`) where the search box is
-  // displayed regardless of the value of sidebar_search_disable:
-  @include media-breakpoint-down(lg) {
-    padding-top: 0 !important;
-    @supports (position: sticky) {
-      max-height: $_max-height !important;
-    }
-  }
-
   @include media-breakpoint-up(md) {
     display: block !important;
   }