From 230ad26ec1d308f6387e7549612d2b4baf244cf2 Mon Sep 17 00:00:00 2001 From: cushon Date: Mon, 18 May 2020 11:08:53 -0700 Subject: [PATCH] Demote a couple of checks that rely on @Generated annotations to warnings to avoid break builds that don't have an `@Generated` annotation available, see discussion in: https://github.com/google/error-prone/issues/1348 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=312115507 --- .../google/errorprone/scanner/BuiltInCheckerSuppliers.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java index d03b4893a3a..82f45b928ed 100644 --- a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java +++ b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java @@ -539,7 +539,6 @@ public static ScannerSupplier errorChecks() { EqualsNaN.class, EqualsReference.class, EqualsWrongThing.class, - ExtendsAutoValue.class, ForOverrideChecker.class, FormatString.class, FormatStringAnnotationChecker.class, @@ -619,7 +618,6 @@ public static ScannerSupplier errorChecks() { RandomCast.class, RandomModInteger.class, RectIntersectReturnValueIgnored.class, - RefersToDaggerCodegen.class, RestrictedApiChecker.class, ReturnValueIgnored.class, SelfAssignment.class, @@ -874,6 +872,7 @@ public static ScannerSupplier errorChecks() { EmptyTopLevelDeclaration.class, EqualsBrokenForNull.class, ExpectedExceptionChecker.class, + ExtendsAutoValue.class, FieldCanBeFinal.class, FieldCanBeLocal.class, FieldMissingNullable.class, @@ -917,6 +916,7 @@ public static ScannerSupplier errorChecks() { RedundantCondition.class, RedundantOverride.class, RedundantThrows.class, + RefersToDaggerCodegen.class, RemoveUnusedImports.class, ScopeOnModule.class, ScopeOrQualifierAnnotationRetention.class,