Fix NPE on JDK13+ when InconsistentHashCode visits a break statement …

…with a label. Fixes #1287 RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=250371701
google · Jun 12, 2019 · 7bb2a77 · 7bb2a77
1 parent 0faf698
commit 7bb2a77
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/InconsistentHashCode.java b/core/src/main/java/com/google/errorprone/bugpatterns/InconsistentHashCode.java
@@ -215,7 +215,8 @@ public Void visitIdentifier(IdentifierTree tree, Void unused) {
     }
 
     private void handleSymbol(Symbol symbol) {
-      if (symbol.getKind() == ElementKind.FIELD
+      if (symbol != null
+          && symbol.getKind() == ElementKind.FIELD
           && !symbol.isStatic()
           && symbol.owner.equals(classSymbol)) {
         String name = symbol.name.toString();

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentHashCodeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentHashCodeTest.java
@@ -128,4 +128,31 @@ public void memoizedHashCode() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void breakLabeledBlock() {
+    helper
+        .addSourceLines(
+            "Test.java",
+            "class Test {",
+            "  private int a;",
+            "  private int b;",
+            "  private int hashCode;",
+            "  public void accessesLocalWithLabeledBreak() {",
+            "    label: {",
+            "      switch (a) {",
+            "        case 0: break label;",
+            "      }",
+            "    }",
+            "  }",
+            "  @Override public boolean equals(Object o) {",
+            "    Test that = (Test) o;",
+            "    return this.a == that.a && this.b == that.b;",
+            "  }",
+            "  @Override public int hashCode() {",
+            "    return hashCode;",
+            "  }",
+            "}")
+        .doTest();
+  }
 }