Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error-prone-javac is missing --release support #784

Closed
cushon opened this issue Oct 20, 2017 · 3 comments
Closed

error-prone-javac is missing --release support #784

cushon opened this issue Oct 20, 2017 · 3 comments
Assignees
@cushon

Comments

@cushon
Copy link
Collaborator

cushon commented Oct 20, 2017

The repackaged jar doesn't contain META-INF/services/com.sun.tools.javac.platform.PlatformProvider, which is needed for --release support. See tbroyer/gradle-errorprone-plugin#52 (comment).
@cushon cushon self-assigned this Oct 20, 2017
@cushon cushon mentioned this issue Oct 20, 2017
Closed
@tbroyer
Copy link
Contributor

tbroyer commented Oct 20, 2017

Fwiw (and I have absolutely no idea what impact it would have), it doesn't include the module-info.class either (which can also be used to declare services)

@cushon
Copy link
Collaborator Author

cushon commented Oct 20, 2017

I think that's going to be harder to fix until we drop support for running on JDK 8, or unless we want to publish separate artifacts for 8 and 9.

@jbduncan jbduncan mentioned this issue Nov 3, 2017
Closed
@cushon
Copy link
Collaborator Author

cushon commented Jan 5, 2018

This is fixed by fcbbd71.

@cushon cushon closed this as completed Jan 5, 2018
@tbroyer tbroyer mentioned this issue Mar 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cushon cushon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbroyer @cushon