Moe Sync #1023
Merged
Moe Sync #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Fixes" #849 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195434516
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195435422
…ot simply the first found RELNOTES: Make SuggestedFixes.removeModifiers remove more than one modifier ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195462090
…'t have to manually regenerate java protos. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195467370
RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195469089
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195472123
RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195489476
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195494047
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195505180
… consistently on the RHS. This is to allow a remove followed by an add not to have overlapping ranges. RELNOTES: None ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195505303
Because TreeMap.put is a no-op for empty ranges, previous empty replacement ranges are not considered in the overlap check. This means that overlapping replacements may not be rejected, depending upon the order of addition. RELNOTES: None ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195542795
Stephan202
reviewed
May 9, 2018
| @@ -734,7 +743,7 @@ public CharSequence getCharContent(boolean ignoreEncodingErrors) throws IOExcept | |||
| try { | |||
| newTask.analyze(); | |||
| } catch (Throwable e) { | |||
| // ignored | |||
| return false; // ¯\_(ツ)_/¯ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Improve error handling in compilesWithFix
"Fixes" #849
RELNOTES: N/A
9f94242
Call out UncheckedIOException as a java8 addition
97f316e
Make SuggestedFixes.removeModifiers remove all modifiers specified, not simply the first found
RELNOTES: Make SuggestedFixes.removeModifiers remove more than one modifier
342d17c
Make the opensource filegroup depend on compiled proto jars so we don't have to manually regenerate java protos.
RELNOTES: N/A
65efe1e
Update documentation around CheckReturnValueIgnored
RELNOTES: n/a
b1f0436
Add fix suggestions to UngroupedOverloads summary
RELNOTES: N/A
d2a0a39
Internal change to the documentation generator
RELNOTES: n/a
e00f68e
Make ByteBufferBackingArray documentation of restrictions clearer
1684e4c
Add support for detecting type annotations across compilation boundaries
RELNOTES: N/A
b86e2f5
SuggestedFixes: make addModifiers and removeModifiers emit whitespace consistently on the RHS.
This is to allow a remove followed by an add not to have overlapping ranges.
RELNOTES: None
2f24601
Handle empty replacement ranges correctly in Replacements.overlap
Because TreeMap.put is a no-op for empty ranges, previous empty replacement ranges are not considered in the overlap check. This means that overlapping replacements may not be rejected, depending upon the order of addition.
RELNOTES: None
b1ba43d