Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #1023

Merged
merged 11 commits into from
May 9, 2018
Merged

Moe Sync #1023

merged 11 commits into from
May 9, 2018

Commits on May 8, 2018

  1. Improve error handling in compilesWithFix 

    "Fixes" #849

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195434516
    @cushon @ronshapiro
    cushon authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    9f94242 View commit details
    Browse the repository at this point in the history

  2. Call out UncheckedIOException as a java8 addition 

    -------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195435422
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    97f316e View commit details
    Browse the repository at this point in the history

  3. Make SuggestedFixes.removeModifiers remove all modifiers specified, n… 

    …ot simply the first found

RELNOTES: Make SuggestedFixes.removeModifiers remove more than one modifier

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195462090
    @awturner @ronshapiro
    awturner authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    342d17c View commit details
    Browse the repository at this point in the history

  4. Make the opensource filegroup depend on compiled proto jars so we don… 

    …'t have to manually regenerate java protos.

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195467370
    @epmjohnston @ronshapiro
    epmjohnston authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    65efe1e View commit details
    Browse the repository at this point in the history

  5. Update documentation around CheckReturnValueIgnored 

    RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195469089
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    b1f0436 View commit details
    Browse the repository at this point in the history

  6. Add fix suggestions to UngroupedOverloads summary 

    RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195472123
    @epmjohnston @ronshapiro
    epmjohnston authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    d2a0a39 View commit details
    Browse the repository at this point in the history

  7. Internal change to the documentation generator 

    RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195489476
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e00f68e View commit details
    Browse the repository at this point in the history

  8. Make ByteBufferBackingArray documentation of restrictions clearer 

    -------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195494047
    @epmjohnston @ronshapiro
    epmjohnston authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    1684e4c View commit details
    Browse the repository at this point in the history

  9. Add support for detecting type annotations across compilation boundaries 

    RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195505180
    @cushon @ronshapiro
    cushon authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    b86e2f5 View commit details
    Browse the repository at this point in the history

  10. SuggestedFixes: make addModifiers and removeModifiers emit whitespace… 

    … consistently on the RHS.

This is to allow a remove followed by an add not to have overlapping ranges.

RELNOTES: None

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195505303
    @awturner @ronshapiro
    awturner authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    2f24601 View commit details
    Browse the repository at this point in the history

  11. Handle empty replacement ranges correctly in Replacements.overlap 

    Because TreeMap.put is a no-op for empty ranges, previous empty replacement ranges are not considered in the overlap check. This means that overlapping replacements may not be rejected, depending upon the order of addition.

RELNOTES: None

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195542795
    @awturner @ronshapiro
    awturner authored and ronshapiro committed May 8, 2018
    Configuration menu
    Copy the full SHA
    b1ba43d View commit details
    Browse the repository at this point in the history