-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple_ga.py algo file #5
Conversation
evojax/algo/simple_ga.py
Outdated
|
||
@best_params.setter | ||
def best_params(self, params): | ||
self._best_params = params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By setting best_params
, we expect the algorithm can continue training from that point, it seems self._best_params
is not used in this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work as intended now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm a little confused about the format of best_params
. Is it the parameters of the elite agent or the whole batch of parameters from the entire population?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the top elite agent's parameter.
Users call NEAlgorithm.best_params
to save/test the model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it and fixed the setter!
Hi, thanks for the PR, I'm testing its performance on the tasks. |
Test results
Notes
|
No description provided.