-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Profiles specified via protobuf #12
Comments
This sounds like an interesting feature to consider. You may also want to look into FHIR shorthand (FSH) as that is intended to make the process of authoring extensions/profiles easier. |
Hey Matt - this is one of the most poorly documented parts of the code base, sorry! Nik is right that Fhir Shorthand is a super interesting project that we're looking in to, too, but to be clear, FhirProto DOES support defining extensions and profiles via a proto - that's what profile_config.proto defines. I know you're working through the protogen example here: https://github.com/google/fhir-examples/tree/master/proto/google/fhir_examples/myprofile, that is an example defining custom extensions and profiles in an implementation guide (you can define Terminologies, too, although it hasn't been added to the example yet). Finally, a wonky technical point - So, e,g., in https://github.com/google/fhir-examples/tree/master/proto/google/fhir_examples/myprofile, the |
Heya - I'm working through the protogen example as well and I'm trying to understand what is intended with the script meant to generate the myprofile.proto Here is my terminal output;
If I understand the flow here - the initial In the rule for generating FHIR protos I see a When I change the When I check |
Currently, it's a little tricky to figure out how to write an extension and/or profile. Assuming the users of this library are already familiar with protobufs, I'd say it'd be simpler if an extension could be generated from a protobuf file (i.e. if
generate_protos_from_config.sh
accepted a.proto
).That said, I am not sure about whether in general a
.proto
has "too much" or "not enough" information to generate an extension (as I still figure out how to write an extension and profile).The text was updated successfully, but these errors were encountered: