Replies: 1 comment
-
It could probably be also implemented for a FilamentInstance by using the existing node map and the name manager? Would lookup by name be slower for FilamentInstances then? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently on an
FilamentAsset
we have the functionalitygetFirstEntityByName
, which is a very handy helper.However, this method doesn't seem to exist for
FilamentInstance
. As we can see here, we only fill a name map for the asset:filament/libs/gltfio/src/AssetLoader.cpp
Lines 571 to 584 in 3728f06
I opened this discussion to ask about how this could be implemented for FilamentInstance (I can make the PR, just wanted to first align with you).
Do you think it makes sense for each instance to also have a name map, which we fill when loading the asset? Or is there a better way where we can spare the memory?
Looking forward to working on this! 🙌
Beta Was this translation helpful? Give feedback.
All reactions