Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltfio: Provide new loader suitable for remeshing #7782

Open
poweifeng opened this issue Apr 19, 2024 · 3 comments
Open

gltfio: Provide new loader suitable for remeshing #7782

poweifeng opened this issue Apr 19, 2024 · 3 comments
Assignees
Labels
gltf Specific to glTF support

Comments

@poweifeng
Copy link
Contributor

poweifeng commented Apr 19, 2024

Context

The current division of work between AssetLoader and ResourceLoader does not fit well with algorithms that require remeshing (e.g. flat shading in #6358).

Proposal

  • Build a new API that will be useful in these use cases.
  • Keep AssetLoader and ResourceLoader for existing clients of the API.
@poweifeng poweifeng added the gltf Specific to glTF support label Apr 19, 2024
@poweifeng poweifeng self-assigned this Apr 19, 2024
@mbalajee
Copy link
Contributor

mbalajee commented Jun 4, 2024

Will this enable the proper normal generation in Android?
#7851

@poweifeng
Copy link
Contributor Author

Will this enable the proper normal generation in Android? #7851

Yes, that's one of the goals of having a new loader.

@mbalajee
Copy link
Contributor

mbalajee commented Jun 4, 2024

Cool so I guess for Android only change that needs to be done is in the resource & asset loader. I actually tried to make some changes and I still don't see the flat normal shading but the model appears all white. can you please take a quick look & suggest if i should make any other changes? This is one of the blocker for us currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gltf Specific to glTF support
Projects
None yet
Development

No branches or pull requests

2 participants