Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Vulkan errors more consistently #8186

Open
emezeske opened this issue Oct 8, 2024 · 0 comments
Open

Log Vulkan errors more consistently #8186

emezeske opened this issue Oct 8, 2024 · 0 comments
Assignees
Labels
vulkan Issues with the Vulkan backend

Comments

@emezeske
Copy link
Contributor

emezeske commented Oct 8, 2024

Is your feature request related to a problem? Please describe.
Yes, related to debugging this issue: #8185

Describe the solution you'd like
Code like this:

FILAMENT_CHECK_POSTCONDITION(result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) 
    << "Cannot acquire in swapchain.";

Should be universally changed to:

FILAMENT_CHECK_POSTCONDITION(result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) 
    << "Cannot acquire in swapchain: " << static_cast<uint32_t>(result);

It's impossible to debug this stuff without even knowing the error code. This pattern is already used in a couple places but it should just be everywhere.

Describe alternatives you've considered
None

OS and backend
N/A

@poweifeng poweifeng added the vulkan Issues with the Vulkan backend label Oct 9, 2024
@poweifeng poweifeng self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulkan Issues with the Vulkan backend
Projects
None yet
Development

No branches or pull requests

2 participants