Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Add allowReadingUnalignedBuffers to all ByteBuffer init methods #8133

Closed
abandy opened this issue Oct 26, 2023 · 2 comments
Closed

Comments

@abandy
Copy link
Contributor

abandy commented Oct 26, 2023

There was a recent updated that added allowReadingUnalignedBuffers to a subset of ByteBuffer init methods.

The init methods that were modified required the data to be UnsafeMutableRawPointer (AFAIK). Since unaligned is associated with reading and not writing it seems that all the other methods should not prevent a user from setting this parameter.

I would like to add allowReadingUnalignedBuffers to all ByteBuffer init methods that accept the data as an input.

@hassila
Copy link
Contributor

hassila commented Nov 23, 2023

Guess this one can be closed as the related PR was merged.

@mustiikhalil
Copy link
Collaborator

Yes correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants