Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axisregistry: Can we remove spaces from Weight fallback names? #2701

Closed
m4rc1e opened this issue Sep 28, 2020 · 2 comments
Closed

axisregistry: Can we remove spaces from Weight fallback names? #2701

m4rc1e opened this issue Sep 28, 2020 · 2 comments

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Sep 28, 2020

@nathan-williams is it possible to remove spaces from the Weight fallback names so "Semi Bold" becomes "SemiBold etc?

This will match our font style names, https://github.com/googlefonts/gftools/blob/master/Lib/gftools/util/google_fonts.py#L85-L95

@davelab6
Copy link
Member

Since the axis' values are not changing I hope this is possible

@nathan-williams
Copy link
Member

nathan-williams commented Oct 2, 2020

I think we should preserve the spaces so that we can use the fallback names to generate labels. It's easier to remove the spaces than add them back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants