-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS Office for Mac as a STAT-related bug catcher #3267
Comments
For the optical size fallbacks, I guess we can't expect another behaviour for now (cf. googlefonts/gf-docs#83). Bodoni Moda, Fraunces, Literata, Truculenta are fine. The problematic ones are:
All of this can be solved by building the font just by using Steps
|
I just find it weird to include the name of the optical size in the style, since it's always the same, but OK.
9 pt SuperSoft Thin Italic, whereas it's the only style which has "SuperSoft"?
Bold twice (this is because there is a SemiBold entry in
Medium twice (this is because there is a SemiBold entry in
The Italic and Regular are inversed (but I agree that it could rather come from a bug in MS Office).
Instances in
The problem is that there is no named instance for the width axis in Archivo, so in software that only manages named instances, Archivo cannot replace Archivo Narrow. |
I'm truly getting fed up of playing whack-a-mole here. We cannot move forward by changing our implementation when the software implementations may be broken (I accept that our older VFs are actually broken). I will chat to MS to understand their naming heuristic for MS Office and see what's the situation. |
Looking at your lists, the modern VFs mainly LGTM so we may not have an issue. It would be fairly trivial to fix the older families since our STAT table generation is automated. However, it will take time since we have to coordinate this work with the upstream repos. |
Hi @m4rc1e Yes, indeed the MS Office for Mac implementation is illogical. If you could find the right person at Microsoft to bring them to their senses, that would be great. And yet MS Office for Mac really does find bugs (even if it was up to specification it wouldn't find very different bugs), and it behaves well with well-made fonts. For the problematic fonts, most of them are the earliest VFs released by Google, true. But some are recent: Roboto for example (because a SemiBold entry in |
For Saira, this relevant part of the specs applies:
https://github.com/googlefonts/gf-docs/tree/main/Spec#fvar-instances |
Well, after comparison: Elided default opsz value:
Non-elided default opsz value:
|
Alright, so before diving into this I thought it good to conduct a full survey of the main branch and look at all of the variable fonts, reviewing each one in Mac Word as that seems to be the best environment for finding inconsistencies / bugs due to its unusual implementation :). Of the 179 font families (this counting each Noto Sans / Noto Serif separately) I found:
Next step will be figuring out the best way to update all of these. :) |
Hi @aaronbell It's great news to see you take on this task! If I may suggest, the current version of tools like According to OT specs: "In a variable font, every element of typographic subfamily names for all of the named instances defined in the 'fvar' table should be reflected in an axis value table" and in the particular implementation of MS Office for Mac, it's essential: it isn't only a display bug, it prevents the selection of the chosen weight. Maybe there should be a FontBakery check for this (a broader check than fonttools/fontbakery#3090)? Also, if at the same time you could implement the requirements of fonttools/fontbakery#3335, it would correct some cases listed in issue #3411 and it would be great! |
Btw, to quote @moyogo (hi Denis!), about the Noto fonts:
|
Another very recent example (yesterday) of a PR where instances of |
@aaronbell and all, please could you update us all here on the status of the work on this? :) |
Hi all, things have been progressing :) I've submitted PRs covering 40 font families with known STAT-table related issues. And already, 6 have been merged in. Please see https://docs.google.com/spreadsheets/d/1ymMU2yrWfItwr7Z5tyPPbx4XqUqF3aMTrf8KJoqVFrU/edit?usp=sharing for the full list of fonts being updated, as well as their current status. |
I believe that all fonts that needed correction have been corrected, and PRs opened for each. Given that, I'm going to go ahead and close this issue :) |
Hi @aaronbell Can you reopen the issue? Correct me if I'm wrong but:
Isn't the general principle not to close an issue until the fix is released, rather than just at the PR stage? |
Actually, I'm going to close this as a dupe against #2391 so that there's only one issue tracking these. Let's continue discussion over there. 😄 |
Office for Mac 2019 & 365 has VF support (only for named instances) since version 16.46 (February 2021 update). According to my tests (dummy fonts with fake
nameID
), the implementation is a mix between thefvar
andSTAT
tables: the named instances are thefvar.NamedInstance
but their names are not extracted from theirsubfamilyNameID
, but are built from theValueNameID
attached to theSTAT.AxisValue
.Prolepsis: I know, that doesn't sound like a valid interpretation of the standard. But with MS Office for Mac, we have one of the earliest implementations of using the
STAT
table, and that reveal a lot of bugs.Some had already been reported in issue #2391, others are new, as for Literata and Roboto: divergence between
STAT.AxisValue
andfvar.NamedInstance
(in both cases, there is a SemiBold infvar
but not inSTAT
). For the Noto*, I selected just one example.Archivo Narrow
Fraunces
League Gothic
Noto * (example with Noto Sans Armenian)
Edit:
Corrected:
Changa (PR #3873)
Crimson Pro (PR #3632)
Dosis (PR #3668)
EB Garamond (PR #3633)
El Messiri (PR #3669)
Epilogue (PR #3634)
Exo (PR #3635)
Exo 2 (PR #3636)
Faustina (PR #3806)
Fira Code (PR #3786)
Inconsolata (PR #3760)
Inter (PR #3781)
Josefin Sans (PR #3664)
Jost (PR #3638)
Jura (PR #3639)
Lemonada (PR #3640)
Literata (PR #3805)
Lora (PR #3641)
Manrope (PR #3642)
Manuale (PR #3643)
Markazi Text (PR #3644)
Mohave (PR #3645)
Mulish (PR #3762)
Orbitron (PR #3670)
Playfair Display (PR #3649)
Public Sans (PR #3650)
Quicksand (PR #3410)
Roboto (PR #3791)
Rosario (PR #3651)
Ruda (PR #3652)
Saira (PR #3746)
Signika (PR #3783, #3782)
Work Sans (PR #3586)
The text was updated successfully, but these errors were encountered: