Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsolata: Version 3.002 added #3760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronbell
Copy link
Collaborator

ef72a96: [gftools-packager] Inconsolata: Version 3.002 added

@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 26, 2021

Cancelled the CI on this one since it has a tonne of instances and will take forever. I'll run it locally.

@aaronbell
Copy link
Collaborator Author

Updated

Inconsolata: Version 3.002 added


5445527: [gftools-packager] Inconsolata: Version 3.002 added

@aaronbell aaronbell force-pushed the gftools_packager_ofl_inconsolata branch from ef72a96 to 5445527 Compare August 26, 2021 17:35
@aaronbell
Copy link
Collaborator Author

A few notes:

  • The original Inconsolata has an instance called "Ligconsolata" in the Glyphs source that is causing problems with the fvar / stat tables. For the purposes of this commit, which aims to solve that problem, I've removed those. However, as this constitutes a degradation in functionality, I didn't want to push this change to the upstream googlefonts repro. As such, I've pushed this from my personal repro.
  • flattencomponents was disabled for this font as the build script includes hinting for the variable font. I've left the hinting in place.
  • I thought the statics included hinting as well (per the first commit), but realized they are just autohinted in the original version, so I have removed with new commit. Sorry!

@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 26, 2021

@aaronbell please cancel the github action each time you push a commit for this pr

@aaronbell
Copy link
Collaborator Author

OK! I didn't realize I could :x
Will do so in the future.

@thlinard
Copy link
Contributor

What holds back this PR?

@RosaWagner RosaWagner requested a review from m4rc1e February 10, 2022 11:16
@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 25, 2022

@RosaWagner I'm currently working on the upstream. Will PR later on today.

@RosaWagner
Copy link
Contributor

Ok cool! I cancelled the CI then ;)

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 29, 2022

Updated

Inconsolata: Version 3.100 added


2ae17fd: [gftools-packager] Inconsolata: Version 3.100 added

@m4rc1e m4rc1e force-pushed the gftools_packager_ofl_inconsolata branch from 5194034 to 2ae17fd Compare April 29, 2022 13:31
@gf-bot
Copy link

gf-bot commented Apr 29, 2022

Fontbakery report

Fontbakery version: 0.8.8

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wdth-wght', 1) [code: summary]


[24] Inconsolata[wdth,wght].ttf
🔥 FAIL: Check glyphs do not have components which are themselves components. (com.google.fonts/check/glyf_nested_components)
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • Aacute
    • Abreve
    • uni1EAE
    • uni1EAE
    • uni1EB6
    • uni1EB6
    • uni1EB0
    • uni1EB0
    • uni1EB2
    • uni1EB4 and 333 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-nested-components]

🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: PPEM must be an integer on hinted fonts. (com.google.fonts/check/integer_ppem_if_hinted)
  • 🔥 FAIL This is a hinted font, so it must have bit 3 set on the flags of the head table, so that PPEM values will be rounded into an integer value.

This can be accomplished by using the 'gftools fix-hinting' command.

create virtualenv

python3 -m venv venv

activate virtualenv

source venv/bin/activate

install gftools

pip install git+https://www.github.com/googlefonts/tools [code: bad-flags]

🔥 FAIL: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • 🔥 FAIL This variable font does not have an avar table. [code: missing-avar]
WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 8:
flag = 0x0A
- Use grayscale rendering
- Use smoothing along multiple axes with ClearType®
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

  • WARN The gasp table has a range of 8 that may be unneccessary. [code: non-ffff-range]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Raph Levien is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure Stylistic Sets have description. (com.google.fonts/check/stylisticset_description)
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss03 lacks a description string on the 'name' table. [code: missing-description]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:
    • uni030C.alt
    • And r.serif
      [code: unreachable-glyphs]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
  • WARN Font is monospaced but 7 glyphs (0.73%) have a different width. You should check the widths of: ['hyphen_greater.dlig', 'exclam_equal_equal.dlig', 'equal_equal_equal.dlig', 'equal_greater.dlig', 'greater_equal.dlig', 'less_hyphen.dlig', 'less_equal.dlig'] [code: mono-outliers]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/inconsolata/Inconsolata[wdth,wght].ttf
Dehinted Size 316.4kb
Hinted Size 337.2kb
Increase 20.8kb
Change 6.6 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.100'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
  • INFO The family name "Inconsolata" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info. [code: name-collision]
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.100"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:
    • cvt
    • fpgm
    • loca
    • prep
    • GPOS
    • GSUB
    • And gasp [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/inconsolata [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 11 49 10 151 0
0% 2% 5% 22% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator

m4rc1e commented May 5, 2022

Just noticed hinting is bodged. Will investigate:

Desktop_Windows_10_chrome_71 0_

@RosaWagner RosaWagner added -- Bad rendering Hinting issue mostly, or inconsistencies among servers and removed - Ready for Review labels May 11, 2022
@RosaWagner RosaWagner added the -- Missing GlyphsLib support Glyphs.app Smart Components/AlternateLayers/RenameGlyphs… label May 27, 2022
@simoncozens
Copy link
Collaborator

What's the glyphsLib issue here?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 14, 2023

Just had another look. Compilation fails with

Can't deal with offset instrokes yet; start corner components on axis (corner _corner.rightSpur in C)
fontmake: Error: In 'Inconsolata.glyphs' -> 'master_ufo/Inconsolata.designspace': Generating fonts from Designspace failed: unsupported operand type(s) for *: 'NoneType' and 'NoneType'

@simoncozens I'm guessing we've part implemented smart components?

@simoncozens
Copy link
Collaborator

Smart components are fine, this is corner components. And fixing that up could be a good job for Georg.

@RosaWagner
Copy link
Contributor

@m4rc1e the last version of builder should have fixed the issue with the reversed contours in manually hinted fonts. the config.yaml should contain:

removeOutlineOverlaps: false
reverseOutlineDirection: false

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 14, 2023

I don't think we support corner components yet so we can't move this forward.

@simoncozens
Copy link
Collaborator

No, we only support pretty basic corner components, not those where the part doesn't start on the axis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Bad rendering Hinting issue mostly, or inconsistencies among servers -- Missing GlyphsLib support Glyphs.app Smart Components/AlternateLayers/RenameGlyphs… I Small Fix bugs fixed but nothing added
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

6 participants