Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literata: Version 3.021 added #3805

Closed
wants to merge 1 commit into from
Closed

Conversation

aaronbell
Copy link
Collaborator

69d495d: [gftools-packager] Literata: Version 3.021 added

1f68cd0: [gftools-packager] ofl/literata remove METADATA "source". #2587

@thlinard
Copy link
Contributor

thlinard commented Sep 3, 2021

ExtraLight instance in STAT but not in fvar (much less of an issue than the other way around, but there is an ExtraLight instance in the API: https://fonts.google.com/specimen/Literata).

@aaronbell
Copy link
Collaborator Author

It isn't clear to me why the ExtraLight instance is not showing up in fvar. The source masters are there and in the designspace doc. It may be that the source / build process needs to be overhauled. In the meantime, this PR fixes up the stat table :).

@thlinard
Copy link
Contributor

thlinard commented Sep 3, 2021

Oh, I hadn't seen: there is also a Black (900) instance missing in fvar. But in fact both <instance> are missing from vf-*.designspace in the source.

But indeed, the issue is less serious this way. 😄

@gf-bot
Copy link

gf-bot commented Sep 3, 2021

Fontbakery report

Fontbakery version: 0.8.2

[12] Literata-Italic[opsz,wght].ttf
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL?
--- Rationale ---
The contents of the DESCRIPTION.en-us.html file are displayed on the Google
Fonts website in the about section of each font family specimen page.
Since all of the Google Fonts collection is composed of libre-licensed fonts,
this check enforces a policy that there must be a hypertext link in that page
directing users to the repository where the font project files are made
available.
Such hosting is typically done on sites like Github, Gitlab, GNU Savannah or any
other git-based version control service.
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
🔥 FAIL: Ensure component transforms do not perform scaling or rotation.
--- Rationale ---
Some families have glyphs which have been constructed by using transformed
components e.g the 'u' being constructed from a flipped 'n'.
From a designers point of view, this sounds like a win (less work). However,
such approaches can lead to rasterization issues, such as having the 'u' not
sitting on the baseline at certain sizes after running the font through
ttfautohint.
As of July 2019, Marc Foley observed that ttfautohint assigns cvt values to
transformed glyphs as if they are not transformed and the result is they render
very badly, and that vttLib does not support flipped components.
When building the font with fontmake, this problem can be fixed by using the
"Decompose Transformed Components" filter.
  • 🔥 FAIL The following glyphs had components with scaling or rotation:

  • exclamdown (component exclam)

  • questiondown (component question)

  • uni0311 (component breve)

  • uni0311.case (component breve.case)

  • exclamdown.case (component exclam)

  • questiondown.case (component question)

  • exclamdown.smcp (component exclam.smcp)

  • questiondown.smcp (component question.smcp)

  • uni1FFE (component uni1FBF)

  • uni037E (component semicolon)

  • anoteleia (component periodcentered)

  • uni0375 (component uni0374)
    [code: transformed-components]

🔥 FAIL: Check glyphs do not have components which are themselves components.
--- Rationale ---
There have been bugs rendering variable fonts with nested components.
Additionally, some static fonts with nested components have been reported to
have rendering and printing issues.
For more info, see:
* https://github.com/googlefonts/fontbakery/issues/2961
* https://github.com/arrowtype/recursive/issues/412
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • uni1EB6
    • uni1EAC
    • uni1EA0
    • uni0202
    • uni1E0C
    • uni1E0E
    • uni01C4
    • uni01C5
    • uni1EC6
    • uni1EB8 and 653 more. [code: found-nested-components]
WARN: DESCRIPTION.en_us.html should end in a linebreak.
--- Rationale ---
Some older text-handling tools sometimes misbehave if the last line of data in a
text file is not terminated with a newline character (also known as '\n').
We know that this is a very small detail, but for the sake of keeping all
DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts
collection, we chose to adopt the practice of placing this final linebreak char
on them.
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check copyright namerecords match license file.
--- Rationale ---
A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.
The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.
Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."
Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.
When in doubt, please choose OFL for new font projects.
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table?
--- Rationale ---
A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.
The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).
The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."
Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.
When in doubt, please choose OFL for new font projects.
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: Are there caret positions declared for every ligature?
--- Rationale ---
All ligatures in a font must have corresponding caret (text cursor) positions
defined in the GDEF table, otherwhise, users may experience issues with caret
rendering.
If using GlyphsApp or UFOs, ligature carets can be defined as anchors with names
starting with 'caret_'. These can be compiled with fontmake as of version
v2.4.0.
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • T + h
    • f + f
    • f + b
    • b + f
    • f + i
    • i + f
    • f + k
    • k + f
    • f + l
    • l + f
    • f + t
    • t + b
    • f + h
    • h + i
    • i + iacute
    • iacute + k
    • k + l
    • l + t

    [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
--- Rationale ---
We want to ensure that any significant changes to the font family are properly
mentioned in the DESCRIPTION file.
In general, it means that the contents of the DESCRIPTION.en_us.html file will
typically change if when font files are updated. Please treat this check as a
reminder to do so whenever appropriate!
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Does the font have a DSIG table?
--- Rationale ---
Microsoft Office 2013 and below products expect fonts to have a digital
signature declared in a DSIG table in order to implement OpenType features. The
EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not
impact Microsoft Office 2016 and above products.
As we approach the EOL date, it is now considered better to completely remove
the table.
But if you still want your font to support OpenType features on Office 2013,
then you may find it handy to add a fake signature on a dummy DSIG table by
running one of the helper scripts provided at
https://github.com/googlefonts/gftools
Reference: https://github.com/googlefonts/fontbakery/issues/1845
  • WARN This font has a digital signature (DSIG table) which is only required - even if only a dummy placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table. [code: found-DSIG]

[11] Literata[opsz,wght].ttf
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL?
--- Rationale ---
The contents of the DESCRIPTION.en-us.html file are displayed on the Google
Fonts website in the about section of each font family specimen page.
Since all of the Google Fonts collection is composed of libre-licensed fonts,
this check enforces a policy that there must be a hypertext link in that page
directing users to the repository where the font project files are made
available.
Such hosting is typically done on sites like Github, Gitlab, GNU Savannah or any
other git-based version control service.
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
🔥 FAIL: Ensure component transforms do not perform scaling or rotation.
--- Rationale ---
Some families have glyphs which have been constructed by using transformed
components e.g the 'u' being constructed from a flipped 'n'.
From a designers point of view, this sounds like a win (less work). However,
such approaches can lead to rasterization issues, such as having the 'u' not
sitting on the baseline at certain sizes after running the font through
ttfautohint.
As of July 2019, Marc Foley observed that ttfautohint assigns cvt values to
transformed glyphs as if they are not transformed and the result is they render
very badly, and that vttLib does not support flipped components.
When building the font with fontmake, this problem can be fixed by using the
"Decompose Transformed Components" filter.
  • 🔥 FAIL The following glyphs had components with scaling or rotation:

  • exclamdown (component exclam)

  • questiondown (component question)

  • bullet (component period)

  • exclamdown.case (component exclam)

  • questiondown.case (component question)

  • exclamdown.smcp (component exclam.smcp)

  • questiondown.smcp (component question.smcp)

  • uni2219 (component bullet)

  • uni1FFE (component uni1FBF)

  • uni0375 (component uni0374)
    [code: transformed-components]

🔥 FAIL: Check glyphs do not have components which are themselves components.
--- Rationale ---
There have been bugs rendering variable fonts with nested components.
Additionally, some static fonts with nested components have been reported to
have rendering and printing issues.
For more info, see:
* https://github.com/googlefonts/fontbakery/issues/2961
* https://github.com/arrowtype/recursive/issues/412
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • uni01C4
    • uni01C5
    • IJacute
    • uni01C6
    • ijacute
    • napostrophe
    • guillemotleft.case
    • guillemotright.case
    • bullet.case
    • uni01C6.smcp and 360 more. [code: found-nested-components]
WARN: DESCRIPTION.en_us.html should end in a linebreak.
--- Rationale ---
Some older text-handling tools sometimes misbehave if the last line of data in a
text file is not terminated with a newline character (also known as '\n').
We know that this is a very small detail, but for the sake of keeping all
DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts
collection, we chose to adopt the practice of placing this final linebreak char
on them.
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check copyright namerecords match license file.
--- Rationale ---
A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.
The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.
Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."
Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.
When in doubt, please choose OFL for new font projects.
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table?
--- Rationale ---
A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.
The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).
The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."
Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.
When in doubt, please choose OFL for new font projects.
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: Are there caret positions declared for every ligature?
--- Rationale ---
All ligatures in a font must have corresponding caret (text cursor) positions
defined in the GDEF table, otherwhise, users may experience issues with caret
rendering.
If using GlyphsApp or UFOs, ligature carets can be defined as anchors with names
starting with 'caret_'. These can be compiled with fontmake as of version
v2.4.0.
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • T + h
    • f + f
    • f + b
    • b + f
    • f + i
    • i + f
    • f + k
    • k + f
    • f + l
    • l + f
    • f + t
    • t + b
    • f + h
    • h + i
    • i + iacute
    • iacute + k
    • k + l
    • l + t

    [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Does the font have a DSIG table?
--- Rationale ---
Microsoft Office 2013 and below products expect fonts to have a digital
signature declared in a DSIG table in order to implement OpenType features. The
EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not
impact Microsoft Office 2016 and above products.
As we approach the EOL date, it is now considered better to completely remove
the table.
But if you still want your font to support OpenType features on Office 2013,
then you may find it handy to add a fake signature on a dummy DSIG table by
running one of the helper scripts provided at
https://github.com/googlefonts/gftools
Reference: https://github.com/googlefonts/fontbakery/issues/1845
  • WARN This font has a digital signature (DSIG table) which is only required - even if only a dummy placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table. [code: found-DSIG]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 6 17 94 15 288 0
0% 1% 4% 22% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@m4rc1e m4rc1e added -- Needs Upstream Resolution Upstream fix required before moving forward and removed - Ready for Review labels Sep 8, 2021
@RosaWagner RosaWagner removed the I VF label Sep 10, 2021
@RosaWagner RosaWagner added I Small Fix bugs fixed but nothing added and removed I Font Upgrade labels Dec 9, 2021
@thlinard
Copy link
Contributor

What holds back this PR?

@RosaWagner RosaWagner self-assigned this Jan 5, 2022
@RosaWagner
Copy link
Contributor

Updated

Literata: Version 3.102;gftools[0.9.29] added


1508d77: [gftools-packager] Literata: Version 3.102;gftools[0.9.29] added

@RosaWagner RosaWagner force-pushed the gftools_packager_ofl_literata branch from 1f68cd0 to 1508d77 Compare May 19, 2023 09:55
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.12a0

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 2 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('opsz-wght-ital', 2) [code: summary]


[21] Literata[opsz,wght].ttf
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
  • 🔥 FAIL Font names are incorrect:
nameID current expected
Family Name Literata Literata 12pt
Subfamily Name Regular Regular
Full Name Literata Regular Literata 12pt Regular
Poscript Name Literata-Regular Literata-12ptRegular
Typographic Family Name N/A Literata
Typographic Subfamily Name N/A 12pt Regular
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0300 COMBINING GRAVE ACCENT: try adding one of: tai-le, coptic, old-permic, cherokee

  • U+0301 COMBINING ACUTE ACCENT: try adding one of: coptic, cherokee, tai-le, osage, tifinagh

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, cherokee, math

  • U+0303 COMBINING TILDE: try adding one of: glagolitic, syriac, math

  • U+0304 COMBINING MACRON: try adding one of: gothic, coptic, caucasian-albanian, cherokee, osage, tifinagh, syriac

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
    43 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, greek, greek-ext, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • A
    • AE
    • AEacute
    • Aacute
    • Abreve
    • Acircumflex
    • Adieresis
    • Agrave
    • Alpha
    • Alphatonos and 1075 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • T + h

    • f + f

    • f + b

    • b + f

    • f + i

    • i + f

    • f + k

    • k + f

    • f + l

    • l + f

    • 8 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
  • WARN The following glyph names may be too long for some legacy systems which may expect a maximum 31-char length limit:
    colonmonetary.osf.BRACKET.varAlt01 [code: legacy-long-names]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • A_acutecombcy

    • A_gravecombcy

    • E_acutecombcy

    • Ereversed_acutecombcy

    • G_tildecomb

    • Hardsign_gravecombcy

    • I_acutecombcy

    • Ia_acutecombcy

    • Ia_gravecombcy

    • Ie_acutecombcy

    • 55 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 0 start point differs in glyph 'percent' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100>

    • Contour 0 start point differs in glyph 'minus' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100>

    • Contour 0 start point differs in glyph 'plusminus' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100>

    • Contour 0 start point differs in glyph 'brevecombcy.case' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100>

    • Contour 0 start point differs in glyph 'brevecombcy.case' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbd150>

    • Contour 0 start point differs in glyph 'perthousand' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100>

    • Contour 0 start point differs in glyph 'plus' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6152c84340> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f6153bbc100> [code: interpolation-issues]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/literata/Literata[opsz,wght].ttf
Dehinted Size 932.4kb
Hinted Size 932.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.102;gftools[0.9.29]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.102;gftools[0.9.29]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/literata [code: family-path]

[22] Literata-Italic[opsz,wght].ttf
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
  • 🔥 FAIL Font names are incorrect:
nameID current expected
Family Name Literata Literata 12pt
Subfamily Name Italic Italic
Full Name Literata Italic Literata 12pt Italic
Poscript Name Literata-Italic Literata-12ptItalic
Typographic Family Name N/A Literata
Typographic Subfamily Name N/A 12pt Italic
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0300 COMBINING GRAVE ACCENT: try adding one of: tai-le, coptic, old-permic, cherokee

  • U+0301 COMBINING ACUTE ACCENT: try adding one of: coptic, cherokee, tai-le, osage, tifinagh

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, cherokee, math

  • U+0303 COMBINING TILDE: try adding one of: glagolitic, syriac, math

  • U+0304 COMBINING MACRON: try adding one of: gothic, coptic, caucasian-albanian, cherokee, osage, tifinagh, syriac

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
    43 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, greek, greek-ext, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • uni00AD
    • uni1F01
    • uni1F03
    • uni1F05
    • uni1F07
    • uni1F09
    • uni1F0B
    • uni1F0D
    • uni1F0F
    • uni1F11 and 77 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • T + h

    • f + f

    • f + b

    • b + f

    • f + i

    • i + f

    • f + k

    • k + f

    • f + l

    • l + f

    • 8 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
  • WARN The following glyph names may be too long for some legacy systems which may expect a maximum 31-char length limit:
    colonmonetary.osf.BRACKET.varAlt01 [code: legacy-long-names]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • A_acutecombcy

    • A_gravecombcy

    • E_acutecombcy

    • Ereversed_acutecombcy

    • G_tildecomb

    • Hardsign_gravecombcy

    • I_acutecombcy

    • Ia_acutecombcy

    • Ia_gravecombcy

    • Ie_acutecombcy

    • 32 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 582 among a set of 12 math glyphs.
    The following math glyphs have a different width, though:

Width = 577:
multiply
[code: width-outliers]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/literata/Literata-Italic[opsz,wght].ttf
Dehinted Size 881.2kb
Hinted Size 881.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.102;gftools[0.9.29]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.102;gftools[0.9.29]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/literata [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 25 72 15 357 0
0% 1% 5% 15% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner added - Ready for Review -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs Upstream Resolution Upstream fix required before moving forward --- blocked labels May 19, 2023
@RosaWagner
Copy link
Contributor

closing this old PR and opening a new one

@RosaWagner RosaWagner closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I Small Fix bugs fixed but nothing added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants