Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amiri Quran: colorv0 SVG table added #6659

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Amiri Quran: colorv0 SVG table added #6659

merged 3 commits into from
Sep 6, 2023

Conversation

RosaWagner
Copy link
Contributor

  • Added SVG tables to Amiri Quran (tested in Indesign that it works well and that indeed without SCG tables it was not displaying colors)
  • Removed "Amiri Quran Colored" that was published under the name "Amiri Quran"

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[24] AmiriQuran-Regular.ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x02D9 (DOT ABOVE)

    • 0x00C1 (LATIN CAPITAL LETTER A WITH ACUTE)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x00C2 (LATIN CAPITAL LETTER A WITH CIRCUMFLEX)

    • 0x00C4 (LATIN CAPITAL LETTER A WITH DIAERESIS)

    • 202 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Version format is correct in 'name' table? (com.google.fonts/check/name/version_format)
  • 🔥 FAIL The NameID.VERSION_STRING (nameID=5) value must follow the pattern "Version X.Y" with X.Y greater than or equal to 1.000. Current version string is: "0.117-H1" [code: bad-version-strings]
🔥 FAIL: Version number has increased since previous release on Google Fonts? (com.google.fonts/check/version_bump)
  • 🔥 FAIL Version number 0.11700439453125 is equal to version on Google Fonts.
  • 🔥 FAIL Version number 0.11700439453125 is equal to version on Google Fonts GitHub repo.
🔥 FAIL: Check font has the expected color font tables. (com.google.fonts/check/colorfont_tables)
  • 🔥 FAIL Font has a COLR v0 table, which is already widely supported, so the SVG table isn't needed. [code: drop-svg]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0305 COMBINING OVERLINE: try adding one of: gothic, elbasan, math, glagolitic, coptic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+0325 COMBINING RING BELOW: try adding syriac

  • U+2003 EM SPACE: try adding nushu

  • U+200C ZERO WIDTH NON-JOINER: try adding one of: tai-tham, rejang, duployan, gunjala-gondi, kayah-li, tagbanwa, mandaic, malayalam, lepcha, cham, mahajani, dogra, thaana, tirhuta, hanifi-rohingya, modi, buginese, tai-viet, tibetan, grantha, hanunoo, telugu, kaithi, manichaean, thai, kharoshthi, phags-pa, syriac, syloti-nagri, tamil, balinese, tai-le, chakma, khudawadi, sundanese, tifinagh, gurmukhi, nko, takri, hatran, khmer, bengali, warang-citi, myanmar, meetei-mayek, siddham, batak, tagalog, new-tai-lue, yi, newa, saurashtra, limbu, psalter-pahlavi, brahmi, javanese, sharada, oriya, sogdian, gujarati, buhid, pahawh-hmong, khojki, kannada, sinhala, devanagari, mongolian, avestan

  • U+200D ZERO WIDTH JOINER: try adding one of: tai-tham, rejang, duployan, gunjala-gondi, kayah-li, tagbanwa, mandaic, malayalam, lepcha, cham, mahajani, dogra, thaana, tirhuta, hanifi-rohingya, modi, buginese, tai-viet, tibetan, grantha, hanunoo, telugu, kaithi, manichaean, thai, kharoshthi, phags-pa, syriac, syloti-nagri, tamil, balinese, tai-le, chakma, khudawadi, sundanese, tifinagh, gurmukhi, nko, takri, bengali, warang-citi, myanmar, meetei-mayek, siddham, batak, tagalog, new-tai-lue, yi, newa, old-hungarian, saurashtra, limbu, psalter-pahlavi, brahmi, javanese, sharada, oriya, gujarati, buhid, pahawh-hmong, khojki, kannada, sinhala, devanagari, mongolian, avestan

  • U+200E LEFT-TO-RIGHT MARK: try adding one of: nko, thaana, syriac, phags-pa

  • U+200F RIGHT-TO-LEFT MARK: try adding one of: nko, thaana, syriac, phags-pa

  • U+202E RIGHT-TO-LEFT OVERRIDE: try adding tifinagh

  • U+202F NARROW NO-BREAK SPACE: try adding one of: mongolian, yi

  • U+25CC DOTTED CIRCLE: try adding one of: caucasian-albanian, bassa-vah, elbasan, kayah-li, lepcha, cham, tibetan, old-permic, syriac, mende-kikakui, chakma, gurmukhi, nko, meetei-mayek, osage, brahmi, pahawh-hmong, sinhala, devanagari, miao, tagbanwa, thaana, mahajani, kaithi, wancho, manichaean, soyombo, tai-le, tifinagh, khmer, siddham, tagalog, masaram-gondi, newa, psalter-pahlavi, marchen, gujarati, buhid, symbols, khojki, mongolian, gunjala-gondi, tirhuta, malayalam, dogra, bhaiksuki, modi, tai-viet, grantha, coptic, telugu, phags-pa, syloti-nagri, tamil, balinese, sundanese, takri, bengali, myanmar, yi, math, oriya, ahom, kannada, new-tai-lue, rejang, duployan, mandaic, hanifi-rohingya, buginese, hanunoo, thai, kharoshthi, khudawadi, lao, hebrew, adlam, batak, music, limbu, javanese, zanabazar-square, sharada, sogdian

Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, menu [code: unreachable-subsetting]

WARN: Description strings in the name table must not exceed 200 characters. (com.google.fonts/check/name/description_max_length)
  • WARN A few name table entries with ID=10 (NameID.DESCRIPTION) are longer than 200 characters. Please check whether those entries are copyright notices mistakenly stored in the description string entries by a bug in an old FontLab version. If that's the case, then such copyright notices must be removed from these entries. [code: too-long]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if uppercase glyphs are vertically centered. (com.google.fonts/check/caps_vertically_centered)
  • WARN Uppercase glyphs are not vertically centered in the em box. [code: vertical-metrics-not-centered]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 529 among a set of 1 math glyphs.
    The following math glyphs have a different width, though:

Width = 480:
less

Width = 551:
equal

Width = 481:
greater

Width = 453:
multiply

Width = 584:
divide

Width = 596:
minus
[code: width-outliers]

WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uniFDFA (U+FDFA): L<<194.0,202.0>--<184.0,304.0>> -> L<<184.0,304.0>--<184.0,305.0>>

    • uniFDFA (U+FDFA): L<<201.0,114.0>--<201.0,122.0>> -> L<<201.0,122.0>--<199.0,144.0>> [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • at (U+0040): B<<415.5,101.0>-<418.0,116.0>-<420.0,122.0>>/B<<420.0,122.0>-<413.0,109.0>-<398.5,87.5>> = 9.865806943084328

    • uni06DD (U+06DD): B<<625.0,455.0>-<639.0,445.0>-<640.0,436.0>>/B<<640.0,436.0>-<641.0,446.0>-<654.0,455.0>> = 12.050784883409548

    • uni06DD (U+06DD): B<<654.0,-123.0>-<641.0,-114.0>-<640.0,-104.0>>/B<<640.0,-104.0>-<639.0,-113.0>-<625.0,-123.0>> = 12.050784883409548

    • uni06E9 (U+06E9): B<<125.0,-37.0>-<94.0,-2.0>-<146.0,39.0>>/B<<146.0,39.0>-<82.0,5.0>-<64.0,60.0>> = 10.274945964037022

    • uni06E9 (U+06E9): B<<157.0,386.0>-<182.0,388.0>-<209.0,355.0>>/B<<209.0,355.0>-<174.0,420.0>-<230.0,438.0>> = 10.988651096493946

    • uni06E9 (U+06E9): B<<200.0,-83.0>-<189.0,-61.0>-<210.0,-23.0>>/B<<210.0,-23.0>-<163.0,-81.0>-<125.0,-37.0>> = 10.09297463998292

    • uni06E9 (U+06E9): B<<230.0,438.0>-<273.0,450.0>-<292.0,388.0>>/B<<292.0,388.0>-<286.0,441.0>-<314.0,454.0>> = 10.578951416906921

    • uni06E9 (U+06E9): B<<314.0,-122.0>-<286.0,-110.0>-<291.0,-59.0>>/B<<291.0,-59.0>-<279.0,-100.0>-<256.0,-107.0>> = 10.714513089739954

    • uni06E9 (U+06E9): B<<357.0,454.0>-<386.0,440.0>-<380.0,388.0>>/B<<380.0,388.0>-<402.0,460.0>-<453.0,433.0>> = 10.40887863680814

    • uni06E9 (U+06E9): B<<44.0,166.0>-<44.0,217.0>-<114.0,210.0>>/B<<114.0,210.0>-<42.0,232.0>-<69.0,284.0>> = 11.280230154486508

    • 9 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • R (U+0052): L<<117.0,113.0>--<116.0,530.0>>

    • R (U+0052): L<<201.0,529.0>--<202.0,325.0>>

    • z (U+007A): L<<285.0,387.0>--<148.0,388.0>> [code: found-semi-vertical]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: i̅ j̅

Your font does not cover the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dutch (Latn, 31,709,104 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/amiriquran/AmiriQuran-Regular.ttf
Dehinted Size 330.1kb
Hinted Size 330.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['0.117-H1'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "0.117-H1"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/amiriquran [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 12 66 9 158 0
0% 2% 5% 27% 4% 63% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@rsheeter rsheeter merged commit 72f3d40 into main Sep 6, 2023
9 checks passed
@rsheeter rsheeter deleted the amiri-colorv0-SVG branch September 6, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added II Color font
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

2 participants