Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badeen Display: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #8521

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Nov 20, 2024

Taken from the upstream repo https://github.com/haniadnansd/Badeen-Display at commit haniadnansd/Badeen-Display@c1370b6.

Resolves #7814

PR Checklist:

  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@yanone yanone added I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts P4 labels Nov 20, 2024
Copy link

FontBakery report

fontbakery version: 0.13.0a5

Check results

[22] BadeenDisplay-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_TransLatin_Arabic glyphset:

FAIL messages Languages
in Farsi, "saria heh" should use a small yeh above, not hamza; both buffers returned uni0654=0@150,-100+0 uni0647=0+592
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_TransLatin_Arabic glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ڜ, ڢ, ڥ, ڧ, ڨ ar_Arab (Arabic)
Some auxiliary glyphs were missing: ؀؁؂؃‌‍‏, ٗ, ٺ, ٻ, ټ, ٽ ur_Arab (Urdu)
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 3	Expected: 4 or 5
  • Glyph name: AE Contours detected: 3 Expected: 2

  • Glyph name: germandbls Contours detected: 2 Expected: 1

  • Glyph name: oslash Contours detected: 2 Expected: 3

  • Glyph name: aogonek Contours detected: 3 Expected: 2

  • Glyph name: eogonek Contours detected: 3 Expected: 2

  • Glyph name: OE Contours detected: 3 Expected: 2

  • Glyph name: oe Contours detected: 4 Expected: 3

  • Glyph name: Uogonek Contours detected: 2 Expected: 1

  • Glyph name: uogonek Contours detected: 2 Expected: 1

  • 12 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 620 among a set of 3 math glyphs.
    The following math glyphs have a different width, though:

Width = 720: plus

Width = 458: less, greater

Width = 642: multiply

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- dotcenterar

- doublestrokear

- gafsarkashabovear

- gafsarkashcenterar

- miniKehehar

- threedotsdownabovear

- threedotsdownbelowar

- threedotsdowncenterar

- threedotsupabovear

- threedotsupbelowar

- 5 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/badeendisplay does not have an article.


    [code: lacks-article]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Hani Alasadi is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, tifinagh, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, tai-le, syriac, malayalam, hebrew, math, todhri, coptic, canadian-aboriginal, old-permic, duployan
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 3 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Southern Tutchone (Latn, 65 speakers), Northern Tutchone (Latn, 85 speakers), Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Han (Latn, 6 speakers), South Central Banda (Latn, 244,000 speakers), Lugbara (Latn, 2,200,000 speakers), Cicipu (Latn, 44,000 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Western Krahn (Latn, 97,800 speakers), Southern Kisi (Latn, 360,000 speakers), Sar (Latn, 500,000 speakers), Bafut (Latn, 158,146 speakers), Heiltsuk (Latn, 300 speakers), Zapotec (Latn, 490,000 speakers), Mundani (Latn, 34,000 speakers), Kaska (Latn, 125 speakers), Gulay (Latn, 250,478 speakers), Avokaya (Latn, 100,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Vute (Latn, 21,000 speakers), Ebira (Latn, 2,200,000 speakers), Abua (Latn, 25,000 speakers), Dan (Latn, 1,099,244 speakers), Kom (Latn, 360,685 speakers), Longto (Latn, 5,000 speakers), Dii (Latn, 71,000 speakers), Ejagham (Latn, 120,000 speakers), Aghem (Latn, 38,843 speakers), Mango (Latn, 77,000 speakers), Yala (Latn, 200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ekpeye (Latn, 226,000 speakers), Ma’di (Latn, 584,000 speakers), Basaa (Latn, 332,940 speakers), Ngbaka (Latn, 1,020,000 speakers), Keliko (Latn, 63,000 speakers), Nzakara (Latn, 50,000 speakers), Fur (Latn, 1,230,163 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mfumte (Latn, 79,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ikwere (Latn, 717,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Navajo (Latn, 166,319 speakers).

[code: soft-dotted]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* six (U+0036): L<<12.0,0.0>--<10.0,300.0>> -> L<<10.0,300.0>--<10.0,455.0>>

* uni0639.fina: L<<297.0,301.0>--<630.0,300.0>> -> L<<630.0,300.0>--<640.0,300.0>>

* uni0639.medi: L<<161.0,301.0>--<612.0,300.0>> -> L<<612.0,300.0>--<622.0,300.0>>

* uni063A.fina: L<<297.0,301.0>--<630.0,300.0>> -> L<<630.0,300.0>--<640.0,300.0>>

* uni063A.medi: L<<161.0,301.0>--<612.0,300.0>> -> L<<612.0,300.0>--<622.0,300.0>>

* uni0666 (U+0666): L<<12.0,0.0>--<10.0,300.0>> -> L<<10.0,300.0>--<10.0,455.0>>

* uni06F6 (U+06F6): L<<12.0,0.0>--<10.0,300.0>> -> L<<10.0,300.0>--<10.0,455.0>>

* yen (U+00A5): L<<30.0,339.0>--<30.0,345.0>> -> L<<30.0,345.0>--<30.0,359.0>>

[code: found-colinear-vectors]

⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* bar (U+007C): L<<10.0,800.0>--<310.0,801.0>>

* bracketleft (U+005B): L<<10.0,800.0>--<310.0,801.0>>

* bracketright (U+005D): L<<10.0,801.0>--<310.0,800.0>>

* e (U+0065): L<<630.0,0.0>--<160.0,1.0>>

* eacute (U+00E9): L<<630.0,0.0>--<160.0,1.0>>

* ecaron (U+011B): L<<630.0,0.0>--<160.0,1.0>>

* ecircumflex (U+00EA): L<<630.0,0.0>--<160.0,1.0>>

* edieresis (U+00EB): L<<630.0,0.0>--<160.0,1.0>>

* edotaccent (U+0117): L<<630.0,0.0>--<160.0,1.0>>

* egrave (U+00E8): L<<630.0,0.0>--<160.0,1.0>>

* 72 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/badeendisplay


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/badeendisplay/BadeenDisplay-Regular.ttf
Dehinted Size 53.7kb
Hinted Size 77.1kb
Increase 23.4kb
Change 43.6 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 13 68 9 161 0
0% 0% 0% 5% 27% 4% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit e26e9bc into main Nov 25, 2024
8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_badeendisplay branch November 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts P4
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Badeen Display
2 participants