Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwrite AR Guides: Version 1.003 added #8662

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Nov 27, 2024

Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@0bd52a3.

Resolves #8541

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@vv-monsalve vv-monsalve added I New Font II Commissioned Commissioned project to do P1 labels Nov 27, 2024
Copy link

FontBakery report

fontbakery version: 0.13.0a5

Check results

[16] PlaywriteARGuides-Regular.ttf
🔥 FAIL Check font follows the Google Fonts vertical metric schema
  • 🔥 FAIL

    The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 2079 when it should be at most 2000


    [code: bad-hhea-range]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 6	Expected: 2
  • Glyph name: quotedbl Contours detected: 6 Expected: 2

  • Glyph name: numbersign Contours detected: 6 Expected: 2

  • Glyph name: dollar Contours detected: 6 Expected: 1, 3 or 5

  • Glyph name: percent Contours detected: 9 Expected: 4 or 5

  • Glyph name: ampersand Contours detected: 7 Expected: 1, 2 or 3

  • Glyph name: quotesingle Contours detected: 5 Expected: 1

  • Glyph name: parenleft Contours detected: 5 Expected: 1

  • Glyph name: parenright Contours detected: 5 Expected: 1

  • Glyph name: asterisk Contours detected: 5 Expected: 1 or 4

  • 715 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check there are no overlapping path segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* cnct.mod_n_o: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,1065.0>--<0.0,1075.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,1065.0>--<0.0,1075.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* 634 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: math, todhri, syriac, hebrew, tai-le, coptic, canadian-aboriginal, duployan, malayalam, tifinagh, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 15 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_f_z has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_z has a counter-clockwise outer contour

* 468 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* A.cur (U+0041): L<<880.0,581.0>--<879.0,175.0>>

* A.cur.ini: L<<880.0,581.0>--<879.0,236.0>>

* H.cur.ini: L<<875.0,628.0>--<876.0,222.0>>

* H.cur: L<<824.0,178.0>--<823.0,601.0>>

* H.cur: L<<877.0,631.0>--<878.0,179.0>>

[code: found-semi-vertical]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/playwritearguides


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritearguides/PlaywriteARGuides-Regular.ttf
Dehinted Size 345.1kb
Hinted Size 345.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 9 75 7 160 0
0% 0% 0% 4% 30% 3% 63% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.

  • We use only the menu subset to avoid the subsetter issues identified with the PW fonts.

@vv-monsalve vv-monsalve requested a review from m4rc1e November 28, 2024 00:46
@m4rc1e m4rc1e merged commit 5c9eca5 into main Nov 28, 2024
8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_playwritearguides branch November 28, 2024 13:03
full_name: "Playwrite AR Guides Regular"
copyright: "Copyright 2023 The Playwrite Project Authors (https://github.com/TypeTogether/Playwrite)"
}
subsets: "latin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vv-monsalve requires subsets revision to menu only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Commissioned Commissioned project to do P1
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Playwrite AR Guides font
3 participants