-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwrite GB J Guides: Version 1.003 added #8663
Conversation
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@0bd52a3. Resolves #8537
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.0a5 Check results[19] PlaywriteGBJGuides-Regular.ttf🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̌ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Northern Tutchone (Latn, 85 speakers), Southern Kisi (Latn, 360,000 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Han (Latn, 6 speakers), Keliko (Latn, 63,000 speakers), Vute (Latn, 21,000 speakers), Navajo (Latn, 166,319 speakers), Makaa (Latn, 221,000 speakers), Heiltsuk (Latn, 300 speakers), Zapotec (Latn, 490,000 speakers), Yala (Latn, 200,000 speakers), Bafut (Latn, 158,146 speakers), Bete-Bendi (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Ma’di (Latn, 584,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Avokaya (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nzakara (Latn, 50,000 speakers), Ekpeye (Latn, 226,000 speakers), Ebira (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Cicipu (Latn, 44,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Western Krahn (Latn, 97,800 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Igbo (Latn, 27,823,640 speakers), Abua (Latn, 25,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Fur (Latn, 1,230,163 speakers), Kaska (Latn, 125 speakers), Teke-Ebo (Latn, 260,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ejagham (Latn, 120,000 speakers), Nateni (Latn, 100,000 speakers), Longto (Latn, 5,000 speakers), Ikwere (Latn, 717,000 speakers), South Central Banda (Latn, 244,000 speakers), Mundani (Latn, 34,000 speakers), Sar (Latn, 500,000 speakers), Southern Tutchone (Latn, 65 speakers), Aghem (Latn, 38,843 speakers), Gulay (Latn, 250,478 speakers).
[code: soft-dotted]⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_f_z has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_z has a counter-clockwise outer contour
* 470 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* A.cur.ini: L<<758.0,494.0>--<757.0,162.0>>
* A.cur: L<<758.0,494.0>--<757.0,139.0>>
* H.cur.ini: L<<701.0,163.0>--<700.0,486.0>>
* H.cur.ini: L<<754.0,514.0>--<755.0,164.0>>
* H.cur: L<<755.0,518.0>--<756.0,147.0>>
[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.65x (1650)
[code: bad-hhea-range]
ℹ️ INFO Check if OS/2 xAvgCharWidth is correct.
- ℹ️ INFO
OS/2 xAvgCharWidth is 643 but it should be 648 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622
[code: xAvgCharWidth-close]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritegbjguides/PlaywriteGBJGuides-Regular.ttf | |
---|---|
Dehinted Size | 350.4kb |
Hinted Size | 350.4kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][18] PlaywriteGBJGuides-Italic.ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
- 🔥 FAIL
Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".
[code: missing]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
-
⚠️ WARNLcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNdcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNlcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNtcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️ WARN Check if each glyph has the recommended amount of contours.
⚠️ WARNThis check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: exclam Contours detected: 6 Expected: 2
-
Glyph name: quotedbl Contours detected: 6 Expected: 2
-
Glyph name: numbersign Contours detected: 6 Expected: 2
-
Glyph name: dollar Contours detected: 6 Expected: 1, 3 or 5
-
Glyph name: percent Contours detected: 9 Expected: 4 or 5
-
Glyph name: ampersand Contours detected: 7 Expected: 1, 2 or 3
-
Glyph name: quotesingle Contours detected: 5 Expected: 1
-
Glyph name: parenleft Contours detected: 5 Expected: 1
-
Glyph name: parenright Contours detected: 5 Expected: 1
-
Glyph name: asterisk Contours detected: 5 Expected: 1 or 4
741 more.
Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]⚠️ WARN Check there are no overlapping path segments
⚠️ WARNThe following glyphs have overlapping path segments:
* cnct.mod_n_o: L<<0.0,-375.0>--<0.0,-365.0>> has the same coordinates as a previous segment.
* cnct.mod_n_o: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.
* cnct.mod_n_o: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.
* cnct.mod_n_o: L<<0.0,875.0>--<0.0,885.0>> has the same coordinates as a previous segment.
* cnct.mod_n_b: L<<0.0,-375.0>--<0.0,-365.0>> has the same coordinates as a previous segment.
* cnct.mod_n_b: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.
* cnct.mod_n_b: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.
* cnct.mod_n_b: L<<0.0,875.0>--<0.0,885.0>> has the same coordinates as a previous segment.
* cnct.mod_n_e: L<<0.0,-375.0>--<0.0,-365.0>> has the same coordinates as a previous segment.
* cnct.mod_n_e: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.
* 634 more.
Use -F or --full-lists to disable shortening of long lists.
[code: overlapping-path-segments]⚠️ WARN Glyph names are all valid?
⚠️ WARNThe following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
circumflexcomb_hookabovecomb.case
[code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
- U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
- U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
- U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
- U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
- U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
- U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
- U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
- U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
- U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: menu
⚠️ WARN Shapes languages in all GF glyphsets.
⚠️ WARNGF_Phonetics_SinoExt glyphset:
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̌ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Northern Tutchone (Latn, 85 speakers), Southern Kisi (Latn, 360,000 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Han (Latn, 6 speakers), Keliko (Latn, 63,000 speakers), Vute (Latn, 21,000 speakers), Navajo (Latn, 166,319 speakers), Makaa (Latn, 221,000 speakers), Heiltsuk (Latn, 300 speakers), Zapotec (Latn, 490,000 speakers), Yala (Latn, 200,000 speakers), Bafut (Latn, 158,146 speakers), Bete-Bendi (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Ma’di (Latn, 584,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Avokaya (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nzakara (Latn, 50,000 speakers), Ekpeye (Latn, 226,000 speakers), Ebira (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Cicipu (Latn, 44,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Western Krahn (Latn, 97,800 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Igbo (Latn, 27,823,640 speakers), Abua (Latn, 25,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Fur (Latn, 1,230,163 speakers), Kaska (Latn, 125 speakers), Teke-Ebo (Latn, 260,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ejagham (Latn, 120,000 speakers), Nateni (Latn, 100,000 speakers), Longto (Latn, 5,000 speakers), Ikwere (Latn, 717,000 speakers), South Central Banda (Latn, 244,000 speakers), Mundani (Latn, 34,000 speakers), Sar (Latn, 500,000 speakers), Southern Tutchone (Latn, 65 speakers), Aghem (Latn, 38,843 speakers), Gulay (Latn, 250,478 speakers).
[code: soft-dotted]⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_f_z has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_z has a counter-clockwise outer contour
* 470 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.65x (1650)
[code: bad-hhea-range]
ℹ️ INFO Check if OS/2 xAvgCharWidth is correct.
- ℹ️ INFO
OS/2 xAvgCharWidth is 643 but it should be 648 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622
[code: xAvgCharWidth-close]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritegbjguides/PlaywriteGBJGuides-Italic.ttf | |
---|---|
Dehinted Size | 355.6kb |
Hinted Size | 355.7kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 21 | 146 | 15 | 302 | 0 |
0% | 0% | 0% | 4% | 30% | 3% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@0bd52a3.
Resolves #8537
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.