Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CactusClassicalSerif-Regular.ttf #8700

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

aaronbell
Copy link
Collaborator

Updating to add vhea/vmtx tables that were dropped.

Fixes #8694 (in conjunction with PR #8699)

Updating to add vhea/vmtx tables that were dropped
@aaronbell aaronbell added II CJK Chinese, Japanese, Korean scripts I Small Fix bugs fixed but nothing added labels Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

FontBakery report

fontbakery version: 0.13.0a6

Check results

[29] CactusClassicalSerif-Regular.ttf
🔥 FAIL Ensure files are not too large.
  • 🔥 FAIL

    Font file is 27.0Mb, larger than limit 9.0Mb


    [code: massive-font]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif', OFL text has 'https://github.com/MoonlitOwen/CactusSerif' and HTML description has 'github.com/MoonlitOwen/CactusSerif'

[code: mismatch]
⚠️ WARN Does the font contain chws and vchw features?
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2
  • Glyph name: uni21B9 Contours detected: 2 Expected: 4

  • Glyph name: uni25CC Contours detected: 19 Expected: 16 or 12

  • Glyph name: fi Contours detected: 1 Expected: 3

  • Glyph name: fl Contours detected: 1 Expected: 2

  • Glyph name: uni210A Contours detected: 3 Expected: 2

  • Glyph name: uni21B9 Contours detected: 2 Expected: 4

  • Glyph name: uni25CC Contours detected: 19 Expected: 16 or 12


[code: contour-count]

⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 576: equal, less, plus, greater, logicalnot, minus

Width = 840: uni3012

[code: width-outliers]
⚠️ WARN Combined length of family and style must not exceed 32 characters.
  • ⚠️ WARN

    Name ID 6 'CactusClassicalSerif-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Check there are no overlapping path segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* uni32A3 (U+32A3): L<<500.0,784.0>--<500.0,848.0>> has the same coordinates as a previous segment.

* uni32A3 (U+32A3): L<<955.0,392.0>--<893.0,392.0>> has the same coordinates as a previous segment.

* glyph2040 (U+341C): L<<833.0,45.0>--<770.0,45.0>> has the same coordinates as a previous segment.

* glyph2151 (U+348B): L<<882.0,812.0>--<883.0,812.0>> has the same coordinates as a previous segment.

* glyph2203 (U+34BF): L<<489.0,18.0>--<427.0,18.0>> has the same coordinates as a previous segment.

* glyph2228 (U+34D8): L<<153.0,455.0>--<217.0,455.0>> has the same coordinates as a previous segment.

* glyph2245 (U+34E9): L<<464.0,24.0>--<526.0,24.0>> has the same coordinates as a previous segment.

* glyph2258 (U+34F6): L<<315.0,543.0>--<316.0,543.0>> has the same coordinates as a previous segment.

* glyph2271 (U+3503): L<<813.0,724.0>--<813.0,723.0>> has the same coordinates as a previous segment.

* glyph2271 (U+3503): L<<813.0,723.0>--<813.0,724.0>> has the same coordinates as a previous segment.

* 4143 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 949, but got 880 instead


    [code: typoAscender]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- cjkradicalspiritonehani

- cjkradicalspirittwohani

- glyph56811

- glyph56899

- glyph57184

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    cjkcompatibilityideograph2f804hani, cjkcompatibilityideograph2f80fhani, cjkcompatibilityideograph2f815hani, cjkcompatibilityideograph2f81ahani, cjkcompatibilityideograph2f822hani, cjkcompatibilityideograph2f828hani, cjkcompatibilityideograph2f833hani, cjkcompatibilityideograph2f83fhani, cjkcompatibilityideograph2f846hani, cjkcompatibilityideograph2f852hani and 384 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/cactusclassicalserif does not have an article.


    [code: lacks-article]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, cherokee, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar
  • U+031B COMBINING HORN: not included in any glyphset definition
  • U+0358 COMBINING DOT ABOVE RIGHT: try adding osage
  • U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: elbasan, math, greek
  • U+0392 GREEK CAPITAL LETTER BETA: try adding one of: elbasan, math, greek 49710 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, cyrillic, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̋ i̍ j̀ j́ j̃ j̄ ɨ̀ ɨ́ ɨ̂ ɨ̃ ɨ̄ ɨ̋ ɨ̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̛̋ i̛̍ i⃝̀ i⃝́ i⃝̂ i⃝̃ i⃝̄ i⃝̆ i⃝̉ i⃝̋ i⃝̌ i⃝̍ i⃞̀ i⃞́ i⃞̂ i⃞̃ i⃞̄ i⃞̆ i⃞̉ i⃞̋

Your font fully covers the following languages that require the soft-dotted feature: Ebira (Latn, 2,200,000 speakers), Abua (Latn, 25,000 speakers), Ekpeye (Latn, 226,000 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Southern Tutchone (Latn, 65 speakers), Avokaya (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Ikwere (Latn, 717,000 speakers), Fur (Latn, 1,230,163 speakers), Basaa (Latn, 332,940 speakers), Northern Tutchone (Latn, 85 speakers), Longto (Latn, 5,000 speakers), Vute (Latn, 21,000 speakers), Nzakara (Latn, 50,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Gulay (Latn, 250,478 speakers), South Central Banda (Latn, 244,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Southern Kisi (Latn, 360,000 speakers), Navajo (Latn, 166,319 speakers), Bete-Bendi (Latn, 100,000 speakers), Dutch (Latn, 31,709,104 speakers), Ngbaka (Latn, 1,020,000 speakers), Sar (Latn, 500,000 speakers), Ejagham (Latn, 120,000 speakers), Kom (Latn, 360,685 speakers), Western Krahn (Latn, 97,800 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ma’di (Latn, 584,000 speakers), Nateni (Latn, 100,000 speakers), Mango (Latn, 77,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Koonzime (Latn, 40,000 speakers), Cicipu (Latn, 44,000 speakers), Dii (Latn, 71,000 speakers), Yala (Latn, 200,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Mundani (Latn, 34,000 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), Dan (Latn, 1,099,244 speakers), Heiltsuk (Latn, 300 speakers), Kaska (Latn, 125 speakers), Bafut (Latn, 158,146 speakers), Keliko (Latn, 63,000 speakers), Makaa (Latn, 221,000 speakers), Han (Latn, 6 speakers), Mfumte (Latn, 79,000 speakers), Zapotec (Latn, 490,000 speakers).

[code: soft-dotted]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* uni3109 (U+3109) has a counter-clockwise outer contour

[code: ccw-outer-contour]

⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* cjkcompatibilityideograph2f86dhani (U+2F86D): B<<635.0,456.0>-<615.0,443.0>-<577.0,438.0>>/L<<577.0,438.0>--<745.0,438.0>> = 7.495857639729836

* cjkcompatibilityideograph2f8d3hani (U+2F8D3): L<<766.0,555.0>--<386.0,555.0>>/L<<386.0,555.0>--<441.0,543.0>> = 12.308015817427924

* cjkcompatibilityideograph2f921hani (U+2F921): B<<332.0,634.0>-<328.0,610.0>-<307.0,607.0>>/L<<307.0,607.0>--<612.0,607.0>> = 8.13010235415596

* cjkcompatibilityideograph2f921hani (U+2F921): L<<200.0,607.0>--<299.0,607.0>>/B<<299.0,607.0>-<288.0,609.0>-<278.0,617.0>> = 10.304846468766044

* cjkcompatibilityideographf910hani (U+F910): L<<422.0,224.0>--<412.0,232.0>>/B<<412.0,232.0>-<435.0,204.0>-<434.0,176.0>> = 11.939531082430465

* cjkcompatibilityideographf91dhani (U+F91D): B<<232.0,461.0>-<333.0,410.0>-<349.0,344.0>>/L<<349.0,344.0>--<349.0,575.0>> = 13.62699485989153

* cjkcompatibilityideographf939hani (U+F939): L<<760.0,380.0>--<751.0,380.0>>/B<<751.0,380.0>-<832.0,365.0>-<883.0,332.0>> = 10.491477012331599

* cjkcompatibilityideographf93bhani (U+F93B): B<<780.0,132.0>-<724.0,223.0>-<697.0,362.0>>/L<<697.0,362.0>--<697.0,18.0>> = 10.992507580267716

* cjkcompatibilityideographf93chani (U+F93C): B<<781.0,130.0>-<727.0,220.0>-<703.0,361.0>>/L<<703.0,361.0>--<703.0,18.0>> = 9.65989307844234

* cjkcompatibilityideographf93dhani (U+F93D): B<<773.0,143.0>-<713.0,245.0>-<686.0,405.0>>/L<<686.0,405.0>--<686.0,20.0>> = 9.578422919460733

* 7018 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* M (U+004D): L<<142.0,48.0>--<143.0,682.0>>

* M (U+004D): L<<738.0,334.0>--<739.0,635.0>>

* Mugrek (U+039C): L<<142.0,48.0>--<143.0,682.0>>

* Mugrek (U+039C): L<<738.0,334.0>--<739.0,635.0>>

* N (U+004E): L<<137.0,48.0>--<138.0,672.0>>

* N (U+004E): L<<183.0,609.0>--<184.0,49.0>>

* N (U+004E): L<<617.0,150.0>--<616.0,680.0>>

* N (U+004E): L<<662.0,681.0>--<661.0,-8.0>>

* Nacute (U+0143): L<<137.0,48.0>--<138.0,672.0>>

* Nacute (U+0143): L<<183.0,609.0>--<184.0,49.0>>

* 1998 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/cactusclassicalserif


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/cactusclassicalserif/CactusClassicalSerif-Regular.ttf
Dehinted Size 27.0Mb
Hinted Size 27.0Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 18 64 10 149 0
0% 0% 1% 7% 26% 4% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

LGTM!
Screenshot 2024-12-12 at 11 05 48

@emmamarichal emmamarichal merged commit 63d247b into main Dec 12, 2024
6 of 8 checks passed
@emmamarichal emmamarichal deleted the CJK_Q4_CactusClassical branch December 12, 2024 10:07
@emmamarichal
Copy link
Collaborator

Same issue than in Chocolate, tofu in sandbox:

Screenshot 2024-12-12 at 15 02 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added II CJK Chinese, Japanese, Korean scripts
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

Missing vertical spacing information for Traditional Chinese fonts
2 participants