-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shafarik: Version 1.001; ttfautohint (v1.8.4.7-5d5b) added #8726
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Taken from the upstream repo https://github.com/slavonic/shafarik at commit slavonic/Shafarik@fba443c. Resolves #8012
Updated |
0c34be6
to
dbecd11
Compare
FontBakery reportfontbakery version: 0.13.0a6 Check results[31] Shafarik-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/slavonic/Shafarik', OFL text has 'https://github.com/slavonic/Shafarik' and HTML description has 'github.com/slavonic/Shafarik' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Check Google Fonts glyph coverage.
[code: missing-codepoints]
|
ofl/shafarik/Shafarik-Regular.ttf | |
---|---|
Dehinted Size | 672.0kb |
Hinted Size | 1.0Mb |
Increase | 364.8kb |
Change | 54.3 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/slavonic/Shafarik
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][2] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 5 | 19 | 59 | 9 | 151 | 0 |
0% | 0% | 2% | 8% | 24% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.13.0a6 Check results[32] Shafarik-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: HTML description has 'github.com/slavonic/Shafarik' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Copyright notices match canonical pattern in fonts
[code: mismatch] 🔥 FAIL Check Google Fonts glyph coverage.
[code: missing-codepoints]
|
ofl/shafarik/Shafarik-Regular.ttf | |
---|---|
Dehinted Size | 672.0kb |
Hinted Size | 1.0Mb |
Increase | 364.8kb |
Change | 54.3 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/slavonic/Shafarik
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][2] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 6 | 19 | 59 | 9 | 150 | 0 |
0% | 0% | 2% | 8% | 24% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Author says the space width is okay here because this font is for Old Church Slavonic whereas the other two are also used for modern-day Church Slavonic. In Old Church Slavonic, the writing was indeed spaced out a lot. |
No description provided.