From 416df8f4ae9c4c2d552820ea3d52476765ab0219 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Tue, 26 Mar 2024 20:02:00 -0700 Subject: [PATCH 1/2] Add BHive Comparison script This patch adds a script for comparing BHive format CSVs (the first column being the hex bb and the second column being the throughput value). The script just outputs the average deviation between the two values. --- gematria/datasets/BUILD.bazel | 8 +++ gematria/datasets/compare_bhive_csv.cc | 88 ++++++++++++++++++++++++++ 2 files changed, 96 insertions(+) create mode 100644 gematria/datasets/compare_bhive_csv.cc diff --git a/gematria/datasets/BUILD.bazel b/gematria/datasets/BUILD.bazel index 3ab5751e..4e32a27d 100644 --- a/gematria/datasets/BUILD.bazel +++ b/gematria/datasets/BUILD.bazel @@ -188,3 +188,11 @@ cc_library( ], deps = ["@com_google_absl//absl/types:span"], ) + +cc_binary( + name = "compare_bhive_csv", + srcs = ["compare_bhive_csv.cc"], + deps = [ + "@llvm-project//llvm:Support", + ], +) diff --git a/gematria/datasets/compare_bhive_csv.cc b/gematria/datasets/compare_bhive_csv.cc new file mode 100644 index 00000000..28c004e5 --- /dev/null +++ b/gematria/datasets/compare_bhive_csv.cc @@ -0,0 +1,88 @@ +// Copyright 2024 Google Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// TODO(boomanaiden154): Refactor this to use LLVM file utilities. +#include +#include +#include +#include + +#include "llvm/ADT/StringExtras.h" +#include "llvm/Support/CommandLine.h" +#include "llvm/Support/Errc.h" +#include "llvm/Support/Error.h" +#include "llvm/Support/raw_ostream.h" + +using namespace llvm; + +static cl::opt InputFilePath1( + "input-file-1", cl::desc("Path to the first input CSV."), cl::init("")); + +static cl::opt InputFilePath2( + "input-file-2", cl::desc("Path to the second input CSV."), cl::init("")); + +int main(int Argc, char **Argv) { + cl::ParseCommandLineOptions(Argc, Argv, "compare_bhive_csv"); + + ExitOnError ExitOnErr("compare_bhive_csv error: "); + + if (InputFilePath1.empty() || InputFilePath2.empty()) + ExitOnErr(llvm::make_error( + errc::invalid_argument, "Input file paths must not be empty")); + + std::ifstream InputFile1 = std::ifstream(InputFilePath1); + std::ifstream InputFile2 = std::ifstream(InputFilePath2); + + double DeviationSum = 0.0; + int FileCount = 0; + + for (std::string File1Line, File2Line; std::getline(InputFile1, File1Line) && + std::getline(InputFile2, File2Line);) { + size_t Line1CommaIndex = File1Line.find(','); + size_t Line2CommaIndex = File2Line.find(','); + + if (Line1CommaIndex == std::string::npos || + Line2CommaIndex == std::string::npos) + ExitOnErr(llvm::make_error(errc::invalid_argument, + "No comma found on input line")); + + std::string_view ThroughputValue1String = + std::string_view(File1Line).substr(Line1CommaIndex + 1, + File1Line.size()); + + std::string_view ThroughputValue2String = + std::string_view(File2Line).substr(Line2CommaIndex + 1, + File2Line.size()); + + int ThroughputValue1 = 0; + int ThroughputValue2 = 0; + + if (!to_integer(StringRef(ThroughputValue1String), ThroughputValue1) || + !to_integer(StringRef(ThroughputValue2String), ThroughputValue2)) { + ExitOnErr(llvm::make_error( + errc::invalid_argument, "Failed to parse integer values")); + } + + double Deviation = + std::abs((double)ThroughputValue1 - (double)ThroughputValue2) / + (double)ThroughputValue1; + DeviationSum += Deviation; + + ++FileCount; + } + + dbgs() << DeviationSum / (double)FileCount << "\n"; + + return 0; +} From e3e32a5059bd99587b3567e001bcc52caef02ae2 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 27 Mar 2024 01:21:08 -0700 Subject: [PATCH 2/2] Minor improvements --- gematria/datasets/compare_bhive_csv.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gematria/datasets/compare_bhive_csv.cc b/gematria/datasets/compare_bhive_csv.cc index 28c004e5..1af59be3 100644 --- a/gematria/datasets/compare_bhive_csv.cc +++ b/gematria/datasets/compare_bhive_csv.cc @@ -12,7 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -// TODO(boomanaiden154): Refactor this to use LLVM file utilities. #include #include #include @@ -27,10 +26,10 @@ using namespace llvm; static cl::opt InputFilePath1( - "input-file-1", cl::desc("Path to the first input CSV."), cl::init("")); + "input-file-a", cl::desc("Path to the first input CSV."), cl::init("")); static cl::opt InputFilePath2( - "input-file-2", cl::desc("Path to the second input CSV."), cl::init("")); + "input-file-b", cl::desc("Path to the second input CSV."), cl::init("")); int main(int Argc, char **Argv) { cl::ParseCommandLineOptions(Argc, Argv, "compare_bhive_csv"); @@ -82,7 +81,7 @@ int main(int Argc, char **Argv) { ++FileCount; } - dbgs() << DeviationSum / (double)FileCount << "\n"; + outs() << "Average deviation: " << DeviationSum / (double)FileCount << "\n"; return 0; }