Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build instructions do not work for paths with ampersand #597

Closed
FHof opened this issue Dec 2, 2020 · 2 comments
Closed

CMake build instructions do not work for paths with ampersand #597

FHof opened this issue Dec 2, 2020 · 2 comments

Comments

@FHof
Copy link

FHof commented Dec 2, 2020

When I clone glog into a folder which has an ampersand in its absolute path, the compilation fails:

~/Downloads/before&after_ampersand/glog$ LC_ALL=C cmake --build build
[  4%] Copying find modules...
/bin/sh: 1: after_ampersand/glog/build/share/glog/cmake: not found
make[2]: *** [CMakeFiles/glog.dir/build.make:62: share/glog/cmake/FindUnwind.cmake] Error 127
make[1]: *** [CMakeFiles/Makefile2:1084: CMakeFiles/glog.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

How to reproduce

@daohu527
Copy link

daohu527 commented Dec 5, 2020

I think it may be a cmake problem rather than glog.

cmake

It works fine with fancy things like dots, eszett (ß), etc. But there are other characters that lead to fail, namely tabulation, newline and any of "#$:;\| (ASCII 9, 10, 34, 35, 36, 58, 59 ,92, 124). Noticeable it works fine with other non-printable characters, single quotes, etc. in directory name.

ref link

It’s better not to not contain the characters in path.

@FHof
Copy link
Author

FHof commented Dec 5, 2020

ok, thank you for the information.

@FHof FHof closed this as completed Dec 5, 2020
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants