Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging_unittest failed for CMAKE_BUILD_TYPE=Release #745

Closed
mikesongming opened this issue Nov 24, 2021 · 1 comment
Closed

logging_unittest failed for CMAKE_BUILD_TYPE=Release #745

mikesongming opened this issue Nov 24, 2021 · 1 comment
Labels
Milestone

Comments

@mikesongming
Copy link

All tests passed for Debug build type, but failed at "DeathNoAllocNewHook" for Release build type.
It seems that NewHook not called when testing new int;

$ ./loggint_unittest
[==========] Running 14 tests from 12 test suites.
[----------] Global test environment set-up.
[----------] 1 test from DeathNoAllocNewHook
[ RUN      ] DeathNoAllocNewHook.logging
Function didn't die (unexpected new): { new int; }

Context
GLOG version: commit cd8fbd5

System: MacOS Montery (Intel i7 CPU inside)

$uname -a
Darwin localhost 21.1.0 Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:23 PDT 2021; root:xnu-8019.41.5~1/RELEASE_X86_64 x86_64

Compiler: clang-13

$clang -v
Apple clang version 13.0.0 (clang-1300.0.29.3)
Target: x86_64-apple-darwin21.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

IDE: VSCode (Version: 1.62.3)
CMAKE: 3.22.0

@sergiud sergiud removed the PR welcome label Jan 3, 2024
@sergiud sergiud added this to the 0.7 milestone Jan 3, 2024
@sergiud
Copy link
Collaborator

sergiud commented Jan 3, 2024

Should be fixed by #1017.

@sergiud sergiud closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants