Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Upgrade deps for azuresb #2799

Merged
merged 5 commits into from
May 27, 2020
Merged

Conversation

johejo
Copy link
Contributor

@johejo johejo commented May 25, 2020

Fixes #2798

Upgrade deps for azuresb
I ran the script below internal/testing and followed some suggestions.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Cannot accept contribution until Google CLA is signed. label May 25, 2020
@johejo
Copy link
Contributor Author

johejo commented May 25, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2799   +/-   ##
=======================================
  Coverage   68.33%   68.33%           
=======================================
  Files         115      115           
  Lines       13336    13336           
=======================================
  Hits         9113     9113           
  Misses       3565     3565           
  Partials      658      658           
Impacted Files Coverage Δ
pubsub/azuresb/azuresb.go 25.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0bd6f...c1bd841. Read the comment docs.

go.mod Show resolved Hide resolved
@vangent vangent merged commit 65f9dc2 into google:master May 27, 2020
@johejo
Copy link
Contributor Author

johejo commented May 27, 2020

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: ambiguous import caused by Azure/go-autorest
3 participants