Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggcr: mounting does not retry on authentication failed #1609

Closed
joaopapereira opened this issue Mar 21, 2023 · 3 comments
Closed

ggcr: mounting does not retry on authentication failed #1609

joaopapereira opened this issue Mar 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@joaopapereira
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.
When mounting an image if 401 is returned by the registry ggcr does not try to do the upload of the bits instead.
There is some logic already to try and retry without mounting, but that only happens when ggcr is doing cross-registry mounts. code in here

To Reproduce

  1. Create 1 image on a repository that needs authentication
  2. Without login try to copy that image to a different repository on the same registry (this should try to mount the blob)

Expected behavior

Our expectation is that this retry would happen also when there was a 401

  • Version of module 0.14.0
  • Registry used (e.g., GCR, ECR, Quay): Harbor
@joaopapereira joaopapereira added the bug Something isn't working label Mar 21, 2023
@joaopapereira joaopapereira changed the title ggcr: ggcr: mounting does not retry on authentication failed Mar 21, 2023
@jonjohnsonjr
Copy link
Collaborator

Should be fixed by #1681

@praveenrewar
Copy link

Hi @jonjohnsonjr! We are still facing this issue. Since both the repositories exists on the same registry, uploading is not retried without mount because of this (origin != w.repo.RegistryStr()) condition.

@jonjohnsonjr
Copy link
Collaborator

Yeah, I believe that's the same issue with #1741

I might just hardcode exclude dockerhub because they keep changing their implementation and breaking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants