Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggcr: 'go test -race' fails on github.com/sigstore/cosign commit 38e2b30b270128998cf7fc819ffa08fca41cda7e #1849

Closed
dmitris opened this issue Nov 22, 2023 · 2 comments
Labels
bug Something isn't working lifecycle/stale

Comments

@dmitris
Copy link

dmitris commented Nov 22, 2023

Describe the bug

Our internal CI builds of a copy of the gitgub.com/sigstore/cosign copy commit 38e2b30 intermittently fail in go test -race ./... step, using go1.21.4. Copy of the race test output: https://gist.github.com/dmitris/eb23914daa0a06924334d077427691b9 (search for "WARNING: DATA RACE").

To Reproduce

Reproduction is difficult - I cannot recreate it on a Mac or on a RHEL8 VM. Even in our CI, the builds sometimes succeed, sometimes fail.

Expected behavior

go test -race ./... completes with no error consistently.

Additional context

github.com/sigstore/cosign uses the latest version v0.16.1 of the github.com/google/go-containerregistry dependency:
https://github.com/sigstore/cosign/blob/38e2b30b270128998cf7fc819ffa08fca41cda7e/go.mod#L20,
same in the latest version: https://github.com/sigstore/cosign/blob/main/go.mod#L20

@dmitris dmitris added the bug Something isn't working label Nov 22, 2023
@dmitris
Copy link
Author

dmitris commented Nov 24, 2023

this should be fixed with #1806 - looking forward to it being merged! 😄

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lifecycle/stale
Projects
None yet
Development

No branches or pull requests

1 participant