Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggcr: Breaking change in aws-sdk-go-v2 leads to broken dependencies in upstream projects #1950

Closed
seternate opened this issue May 21, 2024 · 1 comment
Labels
bug Something isn't working lifecycle/stale

Comments

@seternate
Copy link

Describe the bug

The go library aws-sdk-go-v2 introduced a breaking change with version v1.23. This dependency is used in github.com/awslabs/amazon-ecr-credential-helper/ecr-login in the module pkg/authn/k8schain. Since the used version in ggcr is fairly old it leads to a dependency version mismatch for upstream projects if another dependency uses a newer version of aws-sdk-go-v2. To solve this the dependency github.com/awslabs/amazon-ecr-credential-helper/ecr-login should be updated to its newest version v0.8.0 and a new release of ggcr should be made that this can be used.

For more informations about the problem see following issues:

To Reproduce

See provided issues above.

Expected behavior

  • Update of github.com/awslabs/amazon-ecr-credential-helper/ecr-login to version v0.8.0
  • New version released of ggcr
@seternate seternate added the bug Something isn't working label May 21, 2024
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lifecycle/stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant