You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
daemon.Write dispatches to tarball.Write which writes Compressed layers for each blob.
If the layer is already compressed, this is probably fine. We don't waste any cycles gzipping blobs, piping the compressed bytes into the daemon should take less time, and the daemon can quickly uncompress on the other size.
However, if the incoming v1.Image has layers that haven't yet been compressed, we could avoid the expensive gzip by just writing the uncompressed blobs to the tarball, since the daemon doesn't care about digests at all.
I'd like to fix streaming layers and the tarball package to avoid as much work as possible. The tarball package is way too eager and the stream package isn't flexible enough to do what I described.
The text was updated successfully, but these errors were encountered:
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
daemon.Write
dispatches totarball.Write
which writesCompressed
layers for each blob.If the layer is already compressed, this is probably fine. We don't waste any cycles gzipping blobs, piping the compressed bytes into the daemon should take less time, and the daemon can quickly uncompress on the other size.
However, if the incoming
v1.Image
has layers that haven't yet been compressed, we could avoid the expensive gzip by just writing the uncompressed blobs to the tarball, since the daemon doesn't care about digests at all.cc @nkubala
This is somewhat related to #517
I'd like to fix streaming layers and the tarball package to avoid as much work as possible. The tarball package is way too eager and the stream package isn't flexible enough to do what I described.
The text was updated successfully, but these errors were encountered: