Name the app using the base of the importpath #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradhoekstra
commented
Feb 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 51.12% 51.17% +0.05%
==========================================
Files 75 75
Lines 3458 3478 +20
==========================================
+ Hits 1768 1780 +12
- Misses 1424 1428 +4
- Partials 266 270 +4
Continue to review full report at Codecov.
|
jonjohnsonjr
approved these changes
Feb 21, 2019
3 tasks
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Mar 21, 2019
We were using `stable` and `stable` was suddenly updated to install `ko` from https://github.com/google/ko but unfortunately that version of `ko` didn't include google/go-containerregistry#380 which was the critical change from building binaries at `/ko-app` to building them at `/ko-app/my-pkg` <- which we built some of our functionality around. Now we'll try to pin the image so we aren't caught by surprise by changes again and can decide for ourselves when we want to consume them. (Hopefully old images don't get deleted too often.. 🙏 Or at least not before tektoncd#267 😛)
1 task
2 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Mar 22, 2019
We were using `stable` and `stable` was suddenly updated to install `ko` from https://github.com/google/ko but unfortunately that version of `ko` didn't include google/go-containerregistry#380 which was the critical change from building binaries at `/ko-app` to building them at `/ko-app/my-pkg` <- which we built some of our functionality around. Now we'll try to pin the image so we aren't caught by surprise by changes again and can decide for ourselves when we want to consume them. (Hopefully old images don't get deleted too often.. 🙏 Or at least not before #267 😛)
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Mar 27, 2019
In tektoncd#605, we required that `ko` was recent enough to be *guaranteed* to have `/ko-app/{app}` (see google/go-containerregistry#380). As we now point to `google/ko` and as we have a `ko` release (v0.1), we can require this version for development. Given the requirement above, we can simplify the `entrypoint` copy container `args`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
2 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Mar 27, 2019
In #605, we required that `ko` was recent enough to be *guaranteed* to have `/ko-app/{app}` (see google/go-containerregistry#380). As we now point to `google/ko` and as we have a `ko` release (v0.1), we can require this version for development. Given the requirement above, we can simplify the `entrypoint` copy container `args`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the entrypoint is always '/ko-app', which makes it difficult to tell which ko-built app is which from the host system.
This changes it so that a container built from the importpath
github.com/knative/serving/cmd/autoscalerhas an entrypoint of
/ko-app/autoscalerFixes #375