Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run the generator #1668

Merged
merged 2 commits into from
Apr 3, 2019
Merged

feat: run the generator #1668

merged 2 commits into from
Apr 3, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Apr 3, 2019

Just the result of npm run generate. Looks like no breaking changes, so that's nice :)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@JustinBeckwith JustinBeckwith requested review from bcoe and jkwlui April 3, 2019 22:13
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #1668 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage    98.5%   98.52%   +0.02%     
==========================================
  Files           2        2              
  Lines         267      272       +5     
  Branches        2        2              
==========================================
+ Hits          263      268       +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20edbf...78f8293. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JustinBeckwith JustinBeckwith merged commit 7953bce into master Apr 3, 2019
@grant
Copy link
Contributor

grant commented Apr 13, 2019

Glad nobody noticed the Cloud Run API last week ;)

@JustinBeckwith
Copy link
Contributor Author

People ask me to run the magic script, I run the magic script 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants