Parse JSON numbers to Number type instead of Double. #1288
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all numbers are parsed as Double thus integers are parsed as "int.0", which is wrong according to JSON specification (see www.json.org). With the spec, JSON's number is defined as "int or
int.frac or scientific annotation". This fix parses JSON numbers to Java's Number using NumberFormat parser, which correctly parses JSON numbers to Long and Double respectively. This resolves a lot of issues raised in the past years and also correctly parse "9223372036854775807" to Long.MAX_VALUE without precision loss.