fix: better error message for broken tsconfig.json #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/util.ts
Outdated
| @@ -91,7 +91,7 @@ async function getBase( | |||
|
|
|||
| return contents; | |||
| } catch (err) { | |||
| throw new Error(`${filePath} Not Found`); | |||
| throw new Error(`Error: ${filePath}: ${err}`); | |||
There was a problem hiding this comment.
So good catch - how about instead, we prepend the ${filePath} not found to the original err.message, and then re-throw err so we maintain the full stack trace?
There was a problem hiding this comment.
could you instead capture the stack trace, so that the original stack is in the error, but throw the new message? it feels a little weird mucking with an error (a little too magic).
If `tsconfig.json` cannot be parsed, don't say it's not found.
JustinBeckwith
force-pushed
the
misleading
branch
from
a8c027f
to
feb37d3
Compare
JustinBeckwith
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
tsconfig.jsoncannot be parsed (invalid JSON) we should not say that it's not found.