From 5ed6e43686dec95cb47e444d4cae77060dcc4dc0 Mon Sep 17 00:00:00 2001 From: cpovirk Date: Wed, 5 Oct 2022 12:01:12 -0700 Subject: [PATCH] Make `Primitives` available to GWT/j2cl. I was going to use it in https://github.com/google/truth/commit/3a47110360c0ab5fa224c7aabd5a123da810b7d0, but I found that it wasn't available under those environments. RELNOTES=n/a PiperOrigin-RevId: 479106559 --- .../test/com/google/common/primitives/PrimitivesTest.java | 4 ++++ .../guava/src/com/google/common/primitives/Primitives.java | 4 ++-- .../test/com/google/common/primitives/PrimitivesTest.java | 4 ++++ guava/src/com/google/common/primitives/Primitives.java | 4 ++-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/android/guava-tests/test/com/google/common/primitives/PrimitivesTest.java b/android/guava-tests/test/com/google/common/primitives/PrimitivesTest.java index 8fc55870aa7d..7ee2bdb26167 100644 --- a/android/guava-tests/test/com/google/common/primitives/PrimitivesTest.java +++ b/android/guava-tests/test/com/google/common/primitives/PrimitivesTest.java @@ -18,6 +18,8 @@ import static com.google.common.truth.Truth.assertThat; +import com.google.common.annotations.GwtCompatible; +import com.google.common.annotations.GwtIncompatible; import com.google.common.testing.NullPointerTester; import java.util.Set; import junit.framework.TestCase; @@ -27,6 +29,7 @@ * * @author Kevin Bourrillion */ +@GwtCompatible(emulated = true) public class PrimitivesTest extends TestCase { public void testIsWrapperType() { assertThat(Primitives.isWrapperType(Void.class)).isTrue(); @@ -87,6 +90,7 @@ public void testAllWrapperTypes() { } } + @GwtIncompatible public void testNullPointerExceptions() { NullPointerTester tester = new NullPointerTester(); tester.testAllPublicStaticMethods(Primitives.class); diff --git a/android/guava/src/com/google/common/primitives/Primitives.java b/android/guava/src/com/google/common/primitives/Primitives.java index 7ceed036555a..cfd1eac46d11 100644 --- a/android/guava/src/com/google/common/primitives/Primitives.java +++ b/android/guava/src/com/google/common/primitives/Primitives.java @@ -16,7 +16,7 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.annotations.GwtIncompatible; +import com.google.common.annotations.GwtCompatible; import java.util.Collections; import java.util.LinkedHashMap; import java.util.Map; @@ -29,7 +29,7 @@ * @author Kevin Bourrillion * @since 1.0 */ -@GwtIncompatible +@GwtCompatible @ElementTypesAreNonnullByDefault public final class Primitives { private Primitives() {} diff --git a/guava-tests/test/com/google/common/primitives/PrimitivesTest.java b/guava-tests/test/com/google/common/primitives/PrimitivesTest.java index 8fc55870aa7d..7ee2bdb26167 100644 --- a/guava-tests/test/com/google/common/primitives/PrimitivesTest.java +++ b/guava-tests/test/com/google/common/primitives/PrimitivesTest.java @@ -18,6 +18,8 @@ import static com.google.common.truth.Truth.assertThat; +import com.google.common.annotations.GwtCompatible; +import com.google.common.annotations.GwtIncompatible; import com.google.common.testing.NullPointerTester; import java.util.Set; import junit.framework.TestCase; @@ -27,6 +29,7 @@ * * @author Kevin Bourrillion */ +@GwtCompatible(emulated = true) public class PrimitivesTest extends TestCase { public void testIsWrapperType() { assertThat(Primitives.isWrapperType(Void.class)).isTrue(); @@ -87,6 +90,7 @@ public void testAllWrapperTypes() { } } + @GwtIncompatible public void testNullPointerExceptions() { NullPointerTester tester = new NullPointerTester(); tester.testAllPublicStaticMethods(Primitives.class); diff --git a/guava/src/com/google/common/primitives/Primitives.java b/guava/src/com/google/common/primitives/Primitives.java index 7ceed036555a..cfd1eac46d11 100644 --- a/guava/src/com/google/common/primitives/Primitives.java +++ b/guava/src/com/google/common/primitives/Primitives.java @@ -16,7 +16,7 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.annotations.GwtIncompatible; +import com.google.common.annotations.GwtCompatible; import java.util.Collections; import java.util.LinkedHashMap; import java.util.Map; @@ -29,7 +29,7 @@ * @author Kevin Bourrillion * @since 1.0 */ -@GwtIncompatible +@GwtCompatible @ElementTypesAreNonnullByDefault public final class Primitives { private Primitives() {}