diff --git a/android/guava-tests/test/com/google/common/base/EnumsTest.java b/android/guava-tests/test/com/google/common/base/EnumsTest.java index 10844df5a0f6..66dfe591a7f3 100644 --- a/android/guava-tests/test/com/google/common/base/EnumsTest.java +++ b/android/guava-tests/test/com/google/common/base/EnumsTest.java @@ -20,7 +20,6 @@ import static com.google.common.base.StandardSystemProperty.PATH_SEPARATOR; import static com.google.common.truth.Truth.assertThat; -import com.google.common.annotations.GwtCompatible; import com.google.common.annotations.GwtIncompatible; import com.google.common.annotations.J2ktIncompatible; import com.google.common.collect.ImmutableList; @@ -45,7 +44,7 @@ * * @author Steve McKay */ -@GwtCompatible(emulated = true) +@GwtIncompatible @J2ktIncompatible public class EnumsTest extends TestCase { @@ -117,6 +116,7 @@ private WeakReference doTestClassUnloading() throws Exception { return new WeakReference<>(shadowLoader); } + @GwtIncompatible // stringConverter public void testStringConverter_convert() { Converter converter = Enums.stringConverter(TestEnum.class); assertEquals(TestEnum.CHEETO, converter.convert("CHEETO")); @@ -126,6 +126,7 @@ public void testStringConverter_convert() { assertNull(converter.reverse().convert(null)); } + @GwtIncompatible // stringConverter public void testStringConverter_convertError() { Converter converter = Enums.stringConverter(TestEnum.class); try { @@ -135,6 +136,7 @@ public void testStringConverter_convertError() { } } + @GwtIncompatible // stringConverter public void testStringConverter_reverse() { Converter converter = Enums.stringConverter(TestEnum.class); assertEquals("CHEETO", converter.reverse().convert(TestEnum.CHEETO)); @@ -143,13 +145,14 @@ public void testStringConverter_reverse() { } @J2ktIncompatible - @GwtIncompatible // NullPointerTester + @GwtIncompatible // stringConverter public void testStringConverter_nullPointerTester() throws Exception { Converter converter = Enums.stringConverter(TestEnum.class); NullPointerTester tester = new NullPointerTester(); tester.testAllPublicInstanceMethods(converter); } + @GwtIncompatible // stringConverter public void testStringConverter_nullConversions() { Converter converter = Enums.stringConverter(TestEnum.class); assertNull(converter.convert(null)); @@ -164,6 +167,7 @@ public void testStringConverter_toString() { Enums.stringConverter(TestEnum.class).toString()); } + @GwtIncompatible // stringConverter public void testStringConverter_serialization() { SerializableTester.reserializeAndAssert(Enums.stringConverter(TestEnum.class)); } diff --git a/android/guava/src/com/google/common/base/Enums.java b/android/guava/src/com/google/common/base/Enums.java index 11fbfa8ffad2..d1749f016d08 100644 --- a/android/guava/src/com/google/common/base/Enums.java +++ b/android/guava/src/com/google/common/base/Enums.java @@ -16,7 +16,6 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.annotations.GwtCompatible; import com.google.common.annotations.GwtIncompatible; import com.google.common.annotations.J2ktIncompatible; import java.io.Serializable; @@ -34,7 +33,7 @@ * @author Steve McKay * @since 9.0 */ -@GwtCompatible(emulated = true) +@GwtIncompatible @J2ktIncompatible @ElementTypesAreNonnullByDefault public final class Enums { @@ -108,10 +107,12 @@ static > Map>> getEnum * * @since 16.0 */ + @GwtIncompatible public static > Converter stringConverter(Class enumClass) { return new StringConverter<>(enumClass); } + @GwtIncompatible private static final class StringConverter> extends Converter implements Serializable { diff --git a/guava-gwt/src-super/com/google/common/base/super/com/google/common/base/Platform.java b/guava-gwt/src-super/com/google/common/base/super/com/google/common/base/Platform.java index 1f7dc4e276fc..78d35092682c 100644 --- a/guava-gwt/src-super/com/google/common/base/super/com/google/common/base/Platform.java +++ b/guava-gwt/src-super/com/google/common/base/super/com/google/common/base/Platform.java @@ -32,14 +32,6 @@ static CharMatcher precomputeCharMatcher(CharMatcher matcher) { return matcher; } - static > Optional getEnumIfPresent(Class enumClass, String value) { - try { - return Optional.of(Enum.valueOf(enumClass, value)); - } catch (IllegalArgumentException iae) { - return Optional.absent(); - } - } - static String formatCompact4Digits(double value) { return "" + ((Number) (Object) value).toPrecision(4); } diff --git a/guava-tests/test/com/google/common/base/EnumsTest.java b/guava-tests/test/com/google/common/base/EnumsTest.java index 10844df5a0f6..66dfe591a7f3 100644 --- a/guava-tests/test/com/google/common/base/EnumsTest.java +++ b/guava-tests/test/com/google/common/base/EnumsTest.java @@ -20,7 +20,6 @@ import static com.google.common.base.StandardSystemProperty.PATH_SEPARATOR; import static com.google.common.truth.Truth.assertThat; -import com.google.common.annotations.GwtCompatible; import com.google.common.annotations.GwtIncompatible; import com.google.common.annotations.J2ktIncompatible; import com.google.common.collect.ImmutableList; @@ -45,7 +44,7 @@ * * @author Steve McKay */ -@GwtCompatible(emulated = true) +@GwtIncompatible @J2ktIncompatible public class EnumsTest extends TestCase { @@ -117,6 +116,7 @@ private WeakReference doTestClassUnloading() throws Exception { return new WeakReference<>(shadowLoader); } + @GwtIncompatible // stringConverter public void testStringConverter_convert() { Converter converter = Enums.stringConverter(TestEnum.class); assertEquals(TestEnum.CHEETO, converter.convert("CHEETO")); @@ -126,6 +126,7 @@ public void testStringConverter_convert() { assertNull(converter.reverse().convert(null)); } + @GwtIncompatible // stringConverter public void testStringConverter_convertError() { Converter converter = Enums.stringConverter(TestEnum.class); try { @@ -135,6 +136,7 @@ public void testStringConverter_convertError() { } } + @GwtIncompatible // stringConverter public void testStringConverter_reverse() { Converter converter = Enums.stringConverter(TestEnum.class); assertEquals("CHEETO", converter.reverse().convert(TestEnum.CHEETO)); @@ -143,13 +145,14 @@ public void testStringConverter_reverse() { } @J2ktIncompatible - @GwtIncompatible // NullPointerTester + @GwtIncompatible // stringConverter public void testStringConverter_nullPointerTester() throws Exception { Converter converter = Enums.stringConverter(TestEnum.class); NullPointerTester tester = new NullPointerTester(); tester.testAllPublicInstanceMethods(converter); } + @GwtIncompatible // stringConverter public void testStringConverter_nullConversions() { Converter converter = Enums.stringConverter(TestEnum.class); assertNull(converter.convert(null)); @@ -164,6 +167,7 @@ public void testStringConverter_toString() { Enums.stringConverter(TestEnum.class).toString()); } + @GwtIncompatible // stringConverter public void testStringConverter_serialization() { SerializableTester.reserializeAndAssert(Enums.stringConverter(TestEnum.class)); } diff --git a/guava/src/com/google/common/base/Enums.java b/guava/src/com/google/common/base/Enums.java index 11fbfa8ffad2..d1749f016d08 100644 --- a/guava/src/com/google/common/base/Enums.java +++ b/guava/src/com/google/common/base/Enums.java @@ -16,7 +16,6 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.annotations.GwtCompatible; import com.google.common.annotations.GwtIncompatible; import com.google.common.annotations.J2ktIncompatible; import java.io.Serializable; @@ -34,7 +33,7 @@ * @author Steve McKay * @since 9.0 */ -@GwtCompatible(emulated = true) +@GwtIncompatible @J2ktIncompatible @ElementTypesAreNonnullByDefault public final class Enums { @@ -108,10 +107,12 @@ static > Map>> getEnum * * @since 16.0 */ + @GwtIncompatible public static > Converter stringConverter(Class enumClass) { return new StringConverter<>(enumClass); } + @GwtIncompatible private static final class StringConverter> extends Converter implements Serializable {