From f0c70999725ce61dfb3b4cbfc3313964007e18bd Mon Sep 17 00:00:00 2001 From: cpovirk Date: Fri, 17 May 2024 10:56:04 -0700 Subject: [PATCH] Remove workaround for an Android bug that was fixed at some point before Lollipop. And update the link to the bug that wasn't fixed until later. RELNOTES=n/a PiperOrigin-RevId: 634827341 --- .../test/com/google/common/math/BigIntegerMathTest.java | 9 +-------- .../test/com/google/common/math/BigIntegerMathTest.java | 9 +-------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/android/guava-tests/test/com/google/common/math/BigIntegerMathTest.java b/android/guava-tests/test/com/google/common/math/BigIntegerMathTest.java index bc348230dbd7..a6bca45e4860 100644 --- a/android/guava-tests/test/com/google/common/math/BigIntegerMathTest.java +++ b/android/guava-tests/test/com/google/common/math/BigIntegerMathTest.java @@ -438,9 +438,6 @@ public void testDivNonZero() { private static final BigInteger BAD_FOR_ANDROID_P = new BigInteger("-9223372036854775808"); private static final BigInteger BAD_FOR_ANDROID_Q = new BigInteger("-1"); - private static final BigInteger BAD_FOR_GINGERBREAD_P = new BigInteger("-9223372036854775808"); - private static final BigInteger BAD_FOR_GINGERBREAD_Q = new BigInteger("-4294967296"); - @GwtIncompatible // TODO @AndroidIncompatible // slow public void testDivNonZeroExact() { @@ -449,11 +446,7 @@ public void testDivNonZeroExact() { for (BigInteger p : NONZERO_BIGINTEGER_CANDIDATES) { for (BigInteger q : NONZERO_BIGINTEGER_CANDIDATES) { if (isAndroid && p.equals(BAD_FOR_ANDROID_P) && q.equals(BAD_FOR_ANDROID_Q)) { - // https://code.google.com/p/android/issues/detail?id=196555 - continue; - } - if (isAndroid && p.equals(BAD_FOR_GINGERBREAD_P) && q.equals(BAD_FOR_GINGERBREAD_Q)) { - // Works fine under Marshmallow, so I haven't filed a bug. + // https://issuetracker.google.com/issues/37074172 continue; } diff --git a/guava-tests/test/com/google/common/math/BigIntegerMathTest.java b/guava-tests/test/com/google/common/math/BigIntegerMathTest.java index bc348230dbd7..a6bca45e4860 100644 --- a/guava-tests/test/com/google/common/math/BigIntegerMathTest.java +++ b/guava-tests/test/com/google/common/math/BigIntegerMathTest.java @@ -438,9 +438,6 @@ public void testDivNonZero() { private static final BigInteger BAD_FOR_ANDROID_P = new BigInteger("-9223372036854775808"); private static final BigInteger BAD_FOR_ANDROID_Q = new BigInteger("-1"); - private static final BigInteger BAD_FOR_GINGERBREAD_P = new BigInteger("-9223372036854775808"); - private static final BigInteger BAD_FOR_GINGERBREAD_Q = new BigInteger("-4294967296"); - @GwtIncompatible // TODO @AndroidIncompatible // slow public void testDivNonZeroExact() { @@ -449,11 +446,7 @@ public void testDivNonZeroExact() { for (BigInteger p : NONZERO_BIGINTEGER_CANDIDATES) { for (BigInteger q : NONZERO_BIGINTEGER_CANDIDATES) { if (isAndroid && p.equals(BAD_FOR_ANDROID_P) && q.equals(BAD_FOR_ANDROID_Q)) { - // https://code.google.com/p/android/issues/detail?id=196555 - continue; - } - if (isAndroid && p.equals(BAD_FOR_GINGERBREAD_P) && q.equals(BAD_FOR_GINGERBREAD_Q)) { - // Works fine under Marshmallow, so I haven't filed a bug. + // https://issuetracker.google.com/issues/37074172 continue; }