Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide Bazel BUILD support? #3017

Closed
perezd opened this issue Dec 23, 2017 · 4 comments
Closed

provide Bazel BUILD support? #3017

perezd opened this issue Dec 23, 2017 · 4 comments

Comments

@perezd
Copy link

perezd commented Dec 23, 2017

It'd be nice for users who want to rely on this git repo directly as a bazel target. I've got it working already, its pretty trivial. Only question is should the tests run in bazel too (mirrored) or just leave that as is.

I'd be happy to contribute this, not sure what the right way to do that would be. Some Google projects have a separate "master-with-bazel" branch, others just have it inlined with pom.xml files. I'm flexible, how can I help?

@jbduncan
Copy link
Contributor

Possible duplicate of #2850?

I wonder if it's even worth maintaining a Maven pom.xml and a Bazel BUILD at the same time. From what I've observed of other Google projects, it is difficult to maintain both kinds of files at the same time and can easily lead to them being out of sync. Thus I believe that it's best to wait until Bazel hits an LTS version and fully supports Windows, macOS and Linux, and migrate to Bazel then, as I argue in the linked issue above.

@jbduncan
Copy link
Contributor

Oh, actually, I think this issue could be made a sub-issue of #2850, rather than declaring it as a dupe. It seems to me that the task of creating a BUILD should be a sub-task of an overall Maven-to-Bazel migration.

@jbduncan
Copy link
Contributor

jbduncan commented Dec 23, 2017

I wonder if it's even worth maintaining a Maven pom.xml and a Bazel BUILD at the same time. From what I've observed of other Google projects, it is difficult to maintain both kinds of files at the same time and can easily lead to them being out of sync...

But having said this, I'd be very happy to be proven otherwise, as my knowledge of Bazel is admittedly both very limited and not so current, so it's seems likely that my knowledge about the difficulties of keeping pom.xmls and BUILDs in sync is at least a bit out-of-date.

@ronshapiro
Copy link
Contributor

Let's continue on the linked issue - I think we would definitely support both maven and bazel as we migrated from one to the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants