Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove OSGi Import-Package 'javax.annotation' #1708

Closed
wants to merge 1 commit into from

Conversation

HannesWell
Copy link
Contributor

As suggested (and I assume also intended) in #1173 this PR changes the configuration of the maven-bundle-plugin to completely remove the import of the package javax.annotation, which seems not to be required at runtime.

With PR #1173 respectively #1697 the OSGi package import of javax.annotation;version="[3.0,4)" was only changed to javax.annotation, i.e. the version range was removed.

@mcculls do you want to have a look at this?

Additionally update to latest maven-bundle-plugin 5.1.8.

This package is not required at runtime.

Additionally update to latest maven-bundle-plugin 5.1.8.

Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
@google-cla
Copy link

google-cla bot commented Apr 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@HannesWell HannesWell deleted the removeJavaxAnnotation branch April 25, 2023 23:13
@HannesWell
Copy link
Contributor Author

Thank you @sameb for the quick review and merge.
Can you tell when the next release of guice that contains this change will approximately be done?

@sameb
Copy link
Member

sameb commented Apr 25, 2023

Sure thing! Thanks for the PR!

My hope is to finish merging outstanding pull requests this week and do a cursory sweep over open issues, fixing anything reasonable.

The biggest barrier to a release is a resolution to #1383. At this point, I think we mostly need a Maven expert who can advise on how to structure the POMs to allow pushing an artifact with different deps and bytecode, so we can do a final 6.0 release as-is, and then a 7.0 release using the jakarta namespace as deps (despite the code still referencing javax). As soon as that's settled, I can cut a new release.

@HannesWell
Copy link
Contributor Author

Thanks for the elaboration.

Looks like you already found a solution/plan. Looking forward to the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants