Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wear_keep to datalayer-helper-guide and sample #2385

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

oas004
Copy link
Contributor

@oas004 oas004 commented Sep 12, 2024

WHAT

Add wear_keep.xml to data layer helper guide and sample

From what I understand from https://issuetracker.google.com/issues/348688201#comment4 that is what we needed for resource shrinker to work. I'm not 100% sure so all feedback is more than welcome on that.

WHY

resolves #2281

HOW

Add wear_keep.xml to data layer helper guide and sample

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@oas004 oas004 marked this pull request as ready for review September 12, 2024 16:22
@yschimke
Copy link
Collaborator

cc @kul3r4 FYI

@oas004 oas004 requested a review from yschimke September 13, 2024 14:32
@kul3r4
Copy link
Collaborator

kul3r4 commented Sep 13, 2024

@yschimke
Copy link
Collaborator

@oas004 Good catch by Chiara, can you update that also in this PR? Thanks for your patience with changes bouncing back and forth.

@oas004
Copy link
Contributor Author

oas004 commented Sep 13, 2024

@oas004 Good catch by Chiara, can you update that also in this PR? Thanks for your patience with changes bouncing back and forth.

No worries at all! Thank you for thorough reviews! 🙌 The change that she is referring to isn't that in wear-os sample repository? I can update that as well, but I'm not sure it is possible in this PR? Maybe I'm misunderstanding something?

@kul3r4
Copy link
Collaborator

kul3r4 commented Sep 13, 2024

No worries at all! Thank you for thorough reviews! 🙌 The change that she is referring to isn't that in wear-os sample repository? I can update that as well, but I'm not sure it is possible in this PR? Maybe I'm misunderstanding something?

Yes it's a different repository, happy to review if you want to send a PR there.

@yschimke
Copy link
Collaborator

yschimke commented Sep 13, 2024

@oas004 @kul3r4 oooofffff, sorry. How do I git?!?!?!

@yschimke yschimke merged commit 802df8b into google:main Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android_wear_capabilities and resource shrinker
3 participants