Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of jnp.delete #6085

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Initial implementation of jnp.delete #6085

merged 1 commit into from
Mar 17, 2021

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Mar 16, 2021 •
edited
Loading

This requires the obj argument specifying which indices to delete to be static; in theory it could be dynamic because the output shape can be known at compile time, but I don't know if it's currently possible to express that in terms of JAX primitives (a delete primitive might be the answer to that; I'm not sure).

@google-cla google-cla bot added the cla: yes label Mar 16, 2021
@jakevdp jakevdp requested a review from froystig March 16, 2021 19:02
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Mar 16, 2021
@jakevdp jakevdp force-pushed the delete branch 2 times, most recently from 03325fd to 68a8673 Compare March 16, 2021 23:56
copybara-service bot pushed a commit that referenced this pull request Mar 17, 2021
Copybara import of the project:
c875b90 
--
dacc28c by George Necula <gcnecula@gmail.com>:

[jax2tf] Added instructions for using OSS TensorFlow model server.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479
PiperOrigin-RevId: 363444176
@copybara-service copybara-service bot mentioned this pull request Mar 17, 2021
Merged
copybara-service bot pushed a commit that referenced this pull request Mar 17, 2021
Copybara import of the project:
8f236b7 
--
dacc28c by George Necula <gcnecula@gmail.com>:

[jax2tf] Added instructions for using OSS TensorFlow model server.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479
PiperOrigin-RevId: 363444176
copybara-service bot pushed a commit that referenced this pull request Mar 17, 2021
Internal rollback
d15489f 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479
PiperOrigin-RevId: 363444176
copybara-service bot pushed a commit that referenced this pull request Mar 17, 2021
Internal rollback
d3f41f4 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479
PiperOrigin-RevId: 363444176
copybara-service bot pushed a commit that referenced this pull request Mar 17, 2021
Internal rollback
01ad5fc 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479
PiperOrigin-RevId: 363444176
@jakevdp jakevdp merged commit ba02441 into jax-ml:master Mar 17, 2021
@jakevdp jakevdp deleted the delete branch March 17, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froystig froystig froystig approved these changes

Assignees
No one assigned
Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakevdp @froystig