Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-json to the latest version 🚀 #41

Merged
merged 1 commit into from
May 17, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 17, 2018

Version 5.0.0 of package-json was just published.

Dependency package-json
Current Version 4.0.1
Type dependency

The version 5.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of package-json.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 3 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files           4        4           
  Lines         331      331           
  Branches       70       70           
=======================================
  Hits          270      270           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e4be4...f96c14e. Read the comment docs.

@jinwoo jinwoo merged commit 17ded94 into master May 17, 2018
@jinwoo jinwoo deleted the greenkeeper/package-json-5.0.0 branch May 17, 2018 16:13
@ofrobots
Copy link
Contributor

Doesn't this also require this module to drop support for Node 6? That is, this is semver major.

@jinwoo
Copy link
Member

jinwoo commented May 17, 2018

Did you mean Node 4? Yeah, this should be semver major. I should've changed the PR title.

@jinwoo
Copy link
Member

jinwoo commented May 17, 2018

And I'm not actually sure if we ever supported Node 4. Our CI runs only Node 6, 8, and 10.

@jinwoo
Copy link
Member

jinwoo commented May 17, 2018

Never mind. We used to run CI for node4. But I removed it when I was adding node10: d6e4be4#diff-1d37e48f9ceff6d8030570cd36286a61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants