Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fail arg for errors #84

Merged
merged 2 commits into from
Apr 25, 2019
Merged

feat: fail arg for errors #84

merged 2 commits into from
Apr 25, 2019

Conversation

splix
Copy link
Contributor

@splix splix commented Apr 24, 2019

Command line option to fail (exit 1) if a non-green license found. Useful for CI use

@ofrobots
Copy link
Contributor

Hi @splix. Thanks for the PR. This seems to be a regression I introduced in #65. Thanks for fixing it. I think it should be the default for setExitCode to true – users shouldn't have to pass a flag. Can you make that change?

If the tests give you trouble, let me know, I'd be happy to take a look and get the tests fixed.

@splix
Copy link
Contributor Author

splix commented Apr 24, 2019

Sure, I can make it as a default option. I though it would break existing contract. Should I make an option to exit 0 if non-green found?

@ofrobots
Copy link
Contributor

I don't think this breaks the existing contract. The version of the package published to npm does exit with a non-zero exit code on a non-green license. The regression on the master branch was not released to users.

I don't think we need an option at all.

@splix
Copy link
Contributor Author

splix commented Apr 25, 2019

@ofrobots please take a look at updated version

@ofrobots ofrobots merged commit 2da6cc5 into google:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants