Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require unit test #39

Closed
loverszhaokai opened this issue Mar 2, 2015 · 3 comments
Closed

Require unit test #39

loverszhaokai opened this issue Mar 2, 2015 · 3 comments
Assignees
@davidzchen
Labels
enhancement

Comments

@loverszhaokai
Copy link
Contributor

I think it is better if there are unit tests, such as using gtest.
@sparkprime
Copy link
Contributor

It'd be interesting to see how much code coverage is obtained by running the test suite. There are definitely some holes, especially with different ways of using the C/Python APIs.

I think since the test suite is pretty fast, it is ok as long as there is good coverage. However, there are probably some things that are hard to get good coverage for, and unit tests would be good for that.

@loverszhaokai
Copy link
Contributor Author

Yes! Currently the test suites is the system test. So unit test is also needed by now.

davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 18, 2016
@davidzchen
Add unit test for libjsonnet C API. Move Bazel build targets into BUI…
3418af3 
…LD files in respective directories.

Issue google#39
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 18, 2016
@davidzchen
Add unit tests for lexer.
61114c8 
These tests were transferred from the lexer tests from
google/go-jsonnet.

Issue google#39
@davidzchen davidzchen self-assigned this Mar 18, 2016
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 21, 2016
@davidzchen
Add unit tests for lexer.
571abe8 
These tests were transferred from the lexer tests from
google/go-jsonnet.

Issue google#39
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 21, 2016
@davidzchen
Add unit tests for lexer.
d0f5afa 
These tests were transferred from the lexer tests from
google/go-jsonnet.

Issue google#39
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 24, 2016
@davidzchen
Add unit tests for parser.
0866ee5 
These tests were transferred from the parser tests from
google/go-jsonnet

Issue google#39
@davidzchen davidzchen mentioned this issue Mar 24, 2016
Merged
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 26, 2016
@davidzchen
Add unit tests for parser.
364c5dd 
These tests were transferred from the parser tests from
google/go-jsonnet.

Also normalize the style of recently added source files.

Issue google#39
@sparkprime
Copy link
Contributor

I think we're good with unit tests for the lexer and parser.

This was referenced Nov 20, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzchen davidzchen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sparkprime @loverszhaokai @davidzchen