-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fyi @capri-xiyue |
/lgtm |
/hold |
It was removed in eventing. https://github.com/knative/eventing/pull/3300/files#diff-0ba650882e2e28f7a358f1358430bda6 Either way, we have it skipped because our current Channel does not support dead letter queue... We left the channel one skipped at least... |
need to run update-codegen |
@nachocano You need to run hack/update-codegen.sh |
New changes are detected. LGTM label has been removed. |
The following is the coverage report on the affected files.
|
@nachocano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold |
@nachocano: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I just submitted another PR to update all the deps #1257. You don't need to rebase this PR. |
closing in favor of #1257 |
-->
Release Note
Docs