Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

unpinning eventing and updating deps #1255

Closed
wants to merge 5 commits into from

Conversation

nachocano
Copy link
Member

@nachocano nachocano commented Jun 9, 2020

  • adding missing test image
  • updating deps
  • unpinning CE-SDK
  • Removing TestBrokerDeadLetterSink as it was removed from eventing. We skipped it anyway and we have a Channel one for that. Although we currently don't support Dead Letter queue in our channel

-->

Release Note

NONE

Docs

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Member Author

fyi @capri-xiyue

@capri-xiyue
Copy link
Contributor

/lgtm

@capri-xiyue
Copy link
Contributor

/hold
Wondering whether TestBrokerDeadLetterSink needs to be deleted.

@nachocano
Copy link
Member Author

/hold
Wondering whether TestBrokerDeadLetterSink needs to be deleted.

It was removed in eventing. https://github.com/knative/eventing/pull/3300/files#diff-0ba650882e2e28f7a358f1358430bda6

Either way, we have it skipped because our current Channel does not support dead letter queue... We left the channel one skipped at least...

@nachocano
Copy link
Member Author

need to run update-codegen

@capri-xiyue
Copy link
Contributor

@nachocano You need to run hack/update-codegen.sh

@knative-prow-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/intevents/v1alpha1/topic_lifecycle.go 59.4% 57.6% -1.8
pkg/reconciler/intevents/topic/topic.go 70.2% 69.6% -0.5

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 10, 2020

@nachocano: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-unit-tests c84920a link /test pull-google-knative-gcp-unit-tests
pull-google-knative-gcp-integration-tests c84920a link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-wi-tests c84920a link /test pull-google-knative-gcp-wi-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Jun 10, 2020

/hold
Wondering whether TestBrokerDeadLetterSink needs to be deleted.

/unhold
Synced with @nachocano, the helper method of TestBrokerDeadLetterSinkin eventing got deleted today.Therefore, we need to delete ``TestBrokerDeadLetterSink` or change it to the new test infra

@knative-prow-robot
Copy link
Contributor

@nachocano: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@capri-xiyue
Copy link
Contributor

I just submitted another PR to update all the deps #1257. You don't need to rebase this PR.

@nachocano
Copy link
Member Author

closing in favor of #1257
Thanks @capri-xiyue

@nachocano nachocano closed this Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) needs-rebase size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants